-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
The sp_proc_stmt_statement grammar rule has a huge code block:
sp_proc_stmt_statement:
|
{
|
LEX *lex= thd->lex;
|
Lex_input_stream *lip= YYLIP;
|
|
lex->sphead->reset_lex(thd);
|
lex->sphead->m_tmp_query= lip->get_tok_start();
|
}
|
statement
|
{
|
// The huge code block is here
|
}
|
;
|
After unifying sql_yacc.yy and sql_yacc_ora.yy, there will be two similar rules:
- sp_proc_stmt_statemen, for the default sql_mode
- plsql_sp_proc_stmt_statemen, for sql_mode=ORACLE
To avoid so much duplicate code, we'll move this code into a new method in LEX:
bool sp_proc_stmt_statement_finalize(THD *thd, bool no_lookahead);
|
- blocks
-
MDEV-12518
Unify sql_yacc.yy and sql_yacc_ora.yy
-
-
Closed
Alexander Barkov
made changes -
|
issue.field.resolutiondate
|
2018-11-14 03:38:58.0
|
2018-11-14 03:38:58.232
|
Alexander Barkov
made changes -
|
Fix Version/s
|
|
10.4.1
[ 23228
]
|
|
Fix Version/s
|
10.3
[ 22126
]
|
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
Open
[ 1
]
|
Closed
[ 6
]
|
Sergei Golubchik
made changes -
|
Workflow
|
MariaDB v3
[ 90590
]
|
MariaDB v4
[ 133752
]
|
{"report":{"fcp":1098.3000001907349,"ttfb":281.30000019073486,"pageVisibility":"visible","entityId":70772,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"449b8a72-cae8-4042-8cf2-479c96613b38","navigationType":0,"readyForUser":1174.6000003814697,"redirectCount":0,"resourceLoadedEnd":1453.4000005722046,"resourceLoadedStart":297.80000019073486,"resourceTiming":[{"duration":315.3999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":297.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":297.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":613.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":315.0999994277954,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":298.4000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":298.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":613.5,"responseStart":0,"secureConnectionStart":0},{"duration":323.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":298.80000019073486,"connectEnd":298.80000019073486,"connectStart":298.80000019073486,"domainLookupEnd":298.80000019073486,"domainLookupStart":298.80000019073486,"fetchStart":298.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":298.80000019073486,"responseEnd":622.6000003814697,"responseStart":622.6000003814697,"secureConnectionStart":298.80000019073486},{"duration":378.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":299.4000005722046,"connectEnd":299.4000005722046,"connectStart":299.4000005722046,"domainLookupEnd":299.4000005722046,"domainLookupStart":299.4000005722046,"fetchStart":299.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":299.4000005722046,"responseEnd":677.9000005722046,"responseStart":677.9000005722046,"secureConnectionStart":299.4000005722046},{"duration":382.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":299.6000003814697,"connectEnd":299.6000003814697,"connectStart":299.6000003814697,"domainLookupEnd":299.6000003814697,"domainLookupStart":299.6000003814697,"fetchStart":299.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":299.6000003814697,"responseEnd":682,"responseStart":682,"secureConnectionStart":299.6000003814697},{"duration":382.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":299.69999980926514,"connectEnd":299.69999980926514,"connectStart":299.69999980926514,"domainLookupEnd":299.69999980926514,"domainLookupStart":299.69999980926514,"fetchStart":299.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":299.69999980926514,"responseEnd":682.5,"responseStart":682.5,"secureConnectionStart":299.69999980926514},{"duration":382.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":300,"connectEnd":300,"connectStart":300,"domainLookupEnd":300,"domainLookupStart":300,"fetchStart":300,"redirectEnd":0,"redirectStart":0,"requestStart":300,"responseEnd":682.8000001907349,"responseStart":682.8000001907349,"secureConnectionStart":300},{"duration":468.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":300.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":300.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":768.4000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":383,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":300.30000019073486,"connectEnd":300.30000019073486,"connectStart":300.30000019073486,"domainLookupEnd":300.30000019073486,"domainLookupStart":300.30000019073486,"fetchStart":300.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":300.30000019073486,"responseEnd":683.3000001907349,"responseStart":683.3000001907349,"secureConnectionStart":300.30000019073486},{"duration":468,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":300.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":300.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":768.5,"responseStart":0,"secureConnectionStart":0},{"duration":383.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":300.6000003814697,"connectEnd":300.6000003814697,"connectStart":300.6000003814697,"domainLookupEnd":300.6000003814697,"domainLookupStart":300.6000003814697,"fetchStart":300.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":300.6000003814697,"responseEnd":683.9000005722046,"responseStart":683.9000005722046,"secureConnectionStart":300.6000003814697},{"duration":521.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":321.6000003814697,"connectEnd":321.6000003814697,"connectStart":321.6000003814697,"domainLookupEnd":321.6000003814697,"domainLookupStart":321.6000003814697,"fetchStart":321.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":321.6000003814697,"responseEnd":843,"responseStart":843,"secureConnectionStart":321.6000003814697},{"duration":1116.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":325.80000019073486,"connectEnd":325.80000019073486,"connectStart":325.80000019073486,"domainLookupEnd":325.80000019073486,"domainLookupStart":325.80000019073486,"fetchStart":325.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":325.80000019073486,"responseEnd":1441.9000005722046,"responseStart":1441.9000005722046,"secureConnectionStart":325.80000019073486},{"duration":72.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":780.1000003814697,"connectEnd":780.1000003814697,"connectStart":780.1000003814697,"domainLookupEnd":780.1000003814697,"domainLookupStart":780.1000003814697,"fetchStart":780.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":780.1000003814697,"responseEnd":852.8000001907349,"responseStart":852.8000001907349,"secureConnectionStart":780.1000003814697},{"duration":395.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1047.1999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1047.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1442.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":398.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1048.1000003814697,"connectEnd":1048.1000003814697,"connectStart":1048.1000003814697,"domainLookupEnd":1048.1000003814697,"domainLookupStart":1048.1000003814697,"fetchStart":1048.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":1048.1000003814697,"responseEnd":1446.8000001907349,"responseStart":1446.8000001907349,"secureConnectionStart":1048.1000003814697},{"duration":374.80000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1091.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1091.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1466.5,"responseStart":0,"secureConnectionStart":0},{"duration":404.9000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/53a43b6764f587426c7bb9a150184c00-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1048.5,"connectEnd":1048.5,"connectStart":1048.5,"domainLookupEnd":1048.5,"domainLookupStart":1048.5,"fetchStart":1048.5,"redirectEnd":0,"redirectStart":0,"requestStart":1048.5,"responseEnd":1453.4000005722046,"responseStart":1453.4000005722046,"secureConnectionStart":1048.5}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":99,"responseStart":281,"responseEnd":326,"domLoading":285,"domInteractive":1468,"domContentLoadedEventStart":1468,"domContentLoadedEventEnd":1509,"domComplete":2212,"loadEventStart":2212,"loadEventEnd":2212,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1448.8000001907349},{"name":"bigPipe.sidebar-id.end","time":1449.6000003814697},{"name":"bigPipe.activity-panel-pipe-id.start","time":1449.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":1451.6000003814697},{"name":"activityTabFullyLoaded","time":1525.5}],"measures":[],"correlationId":"7d5cdcbce1e34d","effectiveType":"4g","downlink":9.4,"rtt":0,"serverDuration":99,"dbReadsTimeInMs":14,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
