Type:
Task
Priority:
Major
Resolution:
Fixed
DECLARE has different meanings in the default sql_mode and in sql_mode=ORACLE.
To unify sql_yacc.yy and sql_yacc_ora.yy easier, we'll add sql_mode specific tokens for this keyword and modify the grammar in sql_yacc.yy and sql_yacc_ora.yy accordingly.
Instead of DECLARE_SYM, we'll have separate DECLARE_MARIADB_SYM and DECLARE_ORACLE_SYM.
This will make possible for native and Oracle grammar rules to co-exists in the same *.yy files.
By default, Lex_input_stream::find_keyword() will return DECLARE_MARIADB_SYM, and translate it to DECLARE_ORACLE_SYM in Oracle compatibility mode:
if (m_thd->variables.sql_mode & MODE_ORACLE)
{
switch (symbol->tok) {
...
case DECLARE_MARIADB_SYM: return DECLARE_ORACLE_SYM;
...
}
}
blocks
MDEV-12518
Unify sql_yacc.yy and sql_yacc_ora.yy
Closed
{"report":{"fcp":707.7999992370605,"ttfb":199.0999994277954,"pageVisibility":"visible","entityId":70721,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"f03474ed-362a-4984-984e-d4296a71188e","navigationType":0,"readyForUser":785.5999994277954,"redirectCount":0,"resourceLoadedEnd":1040.6999998092651,"resourceLoadedStart":204.89999961853027,"resourceTiming":[{"duration":11.100000381469727,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":204.89999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":204.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":216,"responseStart":0,"secureConnectionStart":0},{"duration":11.399999618530273,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":205.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":205.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":216.5999994277954,"responseStart":0,"secureConnectionStart":0},{"duration":78.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":205.29999923706055,"connectEnd":205.29999923706055,"connectStart":205.29999923706055,"domainLookupEnd":205.29999923706055,"domainLookupStart":205.29999923706055,"fetchStart":205.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":205.29999923706055,"responseEnd":283.5999994277954,"responseStart":283.5999994277954,"secureConnectionStart":205.29999923706055},{"duration":169.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":205.39999961853027,"connectEnd":205.39999961853027,"connectStart":205.39999961853027,"domainLookupEnd":205.39999961853027,"domainLookupStart":205.39999961853027,"fetchStart":205.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":205.39999961853027,"responseEnd":374.5999994277954,"responseStart":374.5999994277954,"secureConnectionStart":205.39999961853027},{"duration":179.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":205.5,"connectEnd":205.5,"connectStart":205.5,"domainLookupEnd":205.5,"domainLookupStart":205.5,"fetchStart":205.5,"redirectEnd":0,"redirectStart":0,"requestStart":205.5,"responseEnd":384.8999996185303,"responseStart":384.8999996185303,"secureConnectionStart":205.5},{"duration":179.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":205.5999994277954,"connectEnd":205.5999994277954,"connectStart":205.5999994277954,"domainLookupEnd":205.5999994277954,"domainLookupStart":205.5999994277954,"fetchStart":205.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":205.5999994277954,"responseEnd":385.29999923706055,"responseStart":385.29999923706055,"secureConnectionStart":205.5999994277954},{"duration":180.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":205.69999980926514,"connectEnd":205.69999980926514,"connectStart":205.69999980926514,"domainLookupEnd":205.69999980926514,"domainLookupStart":205.69999980926514,"fetchStart":205.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":205.69999980926514,"responseEnd":385.79999923706055,"responseStart":385.79999923706055,"secureConnectionStart":205.69999980926514},{"duration":180.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":205.79999923706055,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":205.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":386.29999923706055,"responseStart":0,"secureConnectionStart":0},{"duration":180.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":205.89999961853027,"connectEnd":205.89999961853027,"connectStart":205.89999961853027,"domainLookupEnd":205.89999961853027,"domainLookupStart":205.89999961853027,"fetchStart":205.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":205.89999961853027,"responseEnd":386.29999923706055,"responseStart":386.29999923706055,"secureConnectionStart":205.89999961853027},{"duration":180.9000005722046,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":206.0999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387,"responseStart":0,"secureConnectionStart":0},{"duration":180.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":206.19999980926514,"connectEnd":206.19999980926514,"connectStart":206.19999980926514,"domainLookupEnd":206.19999980926514,"domainLookupStart":206.19999980926514,"fetchStart":206.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":206.19999980926514,"responseEnd":386.8999996185303,"responseStart":386.8999996185303,"secureConnectionStart":206.19999980926514},{"duration":628.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":206.89999961853027,"connectEnd":206.89999961853027,"connectStart":206.89999961853027,"domainLookupEnd":206.89999961853027,"domainLookupStart":206.89999961853027,"fetchStart":206.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":206.89999961853027,"responseEnd":835.5,"responseStart":835.5,"secureConnectionStart":206.89999961853027},{"duration":777.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":207,"connectEnd":207,"connectStart":207,"domainLookupEnd":207,"domainLookupStart":207,"fetchStart":207,"redirectEnd":0,"redirectStart":0,"requestStart":207,"responseEnd":984.1999998092651,"responseStart":984.1999998092651,"secureConnectionStart":207},{"duration":392.1000003814697,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":443.79999923706055,"connectEnd":443.79999923706055,"connectStart":443.79999923706055,"domainLookupEnd":443.79999923706055,"domainLookupStart":443.79999923706055,"fetchStart":443.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":443.79999923706055,"responseEnd":835.8999996185303,"responseStart":835.8999996185303,"secureConnectionStart":443.79999923706055},{"duration":301.79999923706055,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":700,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":700,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1001.7999992370605,"responseStart":0,"secureConnectionStart":0},{"duration":189.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":851.1999998092651,"connectEnd":851.1999998092651,"connectStart":851.1999998092651,"domainLookupEnd":851.1999998092651,"domainLookupStart":851.1999998092651,"fetchStart":851.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":851.1999998092651,"responseEnd":1040.6999998092651,"responseStart":1040.6999998092651,"secureConnectionStart":851.1999998092651}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":81,"responseStart":199,"responseEnd":203,"domLoading":203,"domInteractive":1066,"domContentLoadedEventStart":1066,"domContentLoadedEventEnd":1106,"domComplete":1453,"loadEventStart":1453,"loadEventEnd":1455,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":988.5},{"name":"bigPipe.sidebar-id.end","time":989.3999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":989.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":992},{"name":"activityTabFullyLoaded","time":1113.5}],"measures":[],"correlationId":"3ae0309f645996","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":68,"dbReadsTimeInMs":10,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}