Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17379

galera_new_cluster throws error in 10.3.10

Details

    Description

      /bin/galera_new_cluster: line 31: return: can only `return' from a function or sourced script

      Galera does seem to bootstrap, but without a successful exit code automation utilities like Puppet, Chef, Ansible, etc may break.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17524 Use 'exit' instead of 'return'

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17628 script galera_new_cluster returns error in 10.3.10

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17715 Bootstrap script uses return instead of exit

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR against 10.3 branch

          Web Link Pull request: Use 'exit' instead of 'return'

          Activity

            Ascending order - Click to sort in descending order
            paulnamuag Paul Namuag added a comment - - edited

            We encountered this as well as running thru automated setup/install using ClusterControl and fails:

            Failed to start MySQL daemon: /usr/bin/galera_new_cluster: line 31: return: can only `return' from a function or sourced script

            As it contains return command, could be invoked as a source script as follows:

            . /usr/bin/galera_new_cluster

            However, I think the script should be improved better than the current and maybe use 

            exit $extcode


            in the end of the shell script.

            Also using 

            zsh

            does not have an issue but bash does.

            Bar.bash

            		 
            $#> cat /bin/galera_new_cluster 
            #!/bin/sh
            		 
             
            		 
            ...
            		 
            ......
            		 
            systemctl set-environment _WSREP_NEW_CLUSTER='--wsrep-new-cluster' && \
            		 
                systemctl start ${1:-mariadb}
            		 
             
            		 
            extcode=$?
            		 
             
            		 
            systemctl set-environment _WSREP_NEW_CLUSTER=''
            		 
             
            		 
            return $extcode

            paulnamuag Paul Namuag added a comment - - edited We encountered this as well as running thru automated setup/install using ClusterControl and fails: Failed to start MySQL daemon: /usr/bin/galera_new_cluster: line 31: return: can only `return' from a function or sourced script As it contains return command, could be invoked as a source script as follows: . /usr/bin/galera_new_cluster However, I think the script should be improved better than the current and maybe use exit $extcode in the end of the shell script. Also using zsh does not have an issue but bash does. Bar.bash $#> cat /bin/galera_new_cluster #!/bin/sh   ... ...... systemctl set-environment _WSREP_NEW_CLUSTER='--wsrep-new-cluster' && \ systemctl start ${1:-mariadb}   extcode=$?   systemctl set-environment _WSREP_NEW_CLUSTER=''   return $extcode
            paulnamuag Paul Namuag added a comment -

            Hi Jan,

            Do you have any feedback of this issue? We would love to hear from you guys.

            Thank you.

            paulnamuag Paul Namuag added a comment - Hi Jan, Do you have any feedback of this issue? We would love to hear from you guys. Thank you.
            jwhite-ac Jason White (AC) added a comment -

            I've also hit this issue - raised it with a solution here: https://github.com/codership/galera/issues/523.

            `return $extcode` needs to change to `exit $extcode`.

            jwhite-ac Jason White (AC) added a comment - I've also hit this issue - raised it with a solution here: https://github.com/codership/galera/issues/523 . `return $extcode` needs to change to `exit $extcode`.
            paulnamuag Paul Namuag added a comment -

            Same here Jason. I use the same approach to resolve the issue. However, in ClusterControl for new installations on MariaDB 10.3 fails coz it hooks up the new package unless this is fix and committed to the repo itself. That would be great.

            paulnamuag Paul Namuag added a comment - Same here Jason. I use the same approach to resolve the issue. However, in ClusterControl for new installations on MariaDB 10.3 fails coz it hooks up the new package unless this is fix and committed to the repo itself. That would be great.
            elenst Elena Stepanova added a comment -

            Linked a pull request

            elenst Elena Stepanova added a comment - Linked a pull request
            mschorm Michal Schorm added a comment - - edited

            As suggested in PR #896, I created PR #897 against branch 10.3

            mschorm Michal Schorm added a comment - - edited As suggested in PR #896 , I created PR #897 against branch 10.3
            stepan.patryshev Stepan Patryshev (Inactive) added a comment -

            Just bumped with it on 10.3.10-1.el7.centos.

            stepan.patryshev Stepan Patryshev (Inactive) added a comment - Just bumped with it on 10.3.10-1.el7.centos.

            People

              jplindst Jan Lindström (Inactive)
              toddstoffel Todd Stoffel (Inactive)
              Votes:
              6 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.