Details
Description
Inside alloc_root() TRASH_ALLOC() unpoisons already aligned size. And f.ex. in case when 6 bytes are requested from MEM_ROOT 8 bytes will be unpoisoned and accessing 1 or 2 bytes after memory block won't be catched by ASAN.
Attachments
Issue Links
- relates to
-
MDEV-15030 Add ASAN instrumentation
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Summary | Improve Valgrind/ASAN memory pool instrumentation | Improve ASAN memory pool instrumentation |
| Description | Inside {{alloc_root()}} {{TRASH_ALLOC()}} unpoisons already aligned size. And f.ex. in case when 6 bytes are requested from {{MEM_ROOT}} 8 bytes will be unpoisoned and accessing 1 or 2 bytes after memory block won't be catched by Valgrind/ASAN. | Inside {{alloc_root()}} {{TRASH_ALLOC()}} unpoisons already aligned size. And f.ex. in case when 6 bytes are requested from {{MEM_ROOT}} 8 bytes will be unpoisoned and accessing 1 or 2 bytes after memory block won't be catched by ASAN. |
| Assignee | Eugene Kosov [ kevg ] | Marko Mäkelä [ marko ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| issue.field.resolutiondate | 2018-09-21 11:47:32.0 | 2018-09-21 11:47:32.579 |
| Component/s | Debug [ 14208 ] | |
| Fix Version/s | 5.5.62 [ 22915 ] | |
| Fix Version/s | 10.0.37 [ 22917 ] | |
| Fix Version/s | 10.2.18 [ 23112 ] | |
| Fix Version/s | 10.3.10 [ 23140 ] | |
| Fix Version/s | 10.1.37 [ 23204 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 5.5 [ 15800 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Assignee | Marko Mäkelä [ marko ] | Eugene Kosov [ kevg ] |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10002 ] | Closed [ 6 ] |
| Link |
This issue relates to |
| Workflow | MariaDB v3 [ 89678 ] | MariaDB v4 [ 133682 ] |