Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16508

spider: sql_mode not maintained between spider node and data nodes

Details

    Description

      This was noticed some time ago and I believe is still present. No explicit bug report was made at the time.

      If the spider node and data nodes have a different sql_mode setup then this may cause issues.

      Example seen was to have sql_mode = STRICT_TRANS_TABLES on data nodes and the spider node and some input data which was accepted on the spider node was rejected by the data node as not being valid. This broke the data load. Other mismatches could also trigger issues.

      My expectation would for the spider node to validate the data nodes' sql_mode matches the spider node, or to push out the spider node's current sql_mode setting (or when it changes as we can have session local sql_nodes) to the data nodes on connection or as the value changes.

      I think this still applies in spider on 10.3.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13383 Spider is not maintaining SQL_MODE across nodes

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-16246 insert timestamp into spider table from mysqldump gets wrong time zone.

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            sjmudd Simon Mudd added a comment -

            I would also expect this to affect:

            • timezone
            • character set / collation

            Basically some of the other session attributes which if not managed consistently between client and server can cause issues.

            sjmudd Simon Mudd added a comment - I would also expect this to affect: timezone character set / collation Basically some of the other session attributes which if not managed consistently between client and server can cause issues.
            Kentoku Kentoku Shiba (Inactive) added a comment - - edited

            The timezone issue is fixed at MDEV-16246.
            Character set/collation is adjusted when Spider rewrite plugin is used. (MDEV-16967)
            Please let me know if you have another problem about character set/collation.

            About sql_mode, I added a pushdown feature with the following option.

            • spider_sync_sql_mode
              Local sql_mode synchronous existence to remote server.
              0 : not synchronize.
              1 : synchronize.
              The default value is 1

            2f4e5d5

            Kentoku Kentoku Shiba (Inactive) added a comment - - edited The timezone issue is fixed at MDEV-16246 . Character set/collation is adjusted when Spider rewrite plugin is used. ( MDEV-16967 ) Please let me know if you have another problem about character set/collation. About sql_mode, I added a pushdown feature with the following option. spider_sync_sql_mode Local sql_mode synchronous existence to remote server. 0 : not synchronize. 1 : synchronize. The default value is 1 2f4e5d5
            Kentoku Kentoku Shiba (Inactive) added a comment -

            Please review this changes.

            Kentoku Kentoku Shiba (Inactive) added a comment - Please review this changes.
            willhan willhan added a comment -

            kentoku
            It's ok

            willhan willhan added a comment - kentoku It's ok
            Kentoku Kentoku Shiba (Inactive) added a comment -

            willhan
            Thank you for checking this.
            I just merged.

            Kentoku Kentoku Shiba (Inactive) added a comment - willhan Thank you for checking this. I just merged.

            People

              Kentoku Kentoku Shiba (Inactive)
              sjmudd Simon Mudd
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.