Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16334

Incorrect ALTER TABLE for changing column option

Details

    Description

      A code refactoring accidentally changed ALTER_COLUMN_OPTION and ALTER_COLUMN_STORAGE_TYPE to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.

      The impact of this bug should be incorrect operation of Mroonga when the column options GROONGA_TYPE, FLAGS are changed.

      InnoDB does not define any column options, only table options, so the flag ALTER_COLUMN_OPTION should never be set.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Component/s Storage Engine - InnoDB [ 10129 ]
            marko Marko Mäkelä made changes -
            Description A [code refactoring|https://github.com/MariaDB/server/commit/2dbeebdb16436e3c2723cd483aaf21d93de799d6] accidentally changed {{ALTER_COLUMN_OPTION}} and {{ALTER_COLUMN_STORAGE_TYPE}} to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.

            The impact of this bug could be incorrect operation of Mroonga, and unnecessary use of {{ALGORITHM=COPY}} in InnoDB when the column options are changed.

            For InnoDB, the impact seems to be that changing any of the InnoDB table options would only be allowed with {{ALGORITHM=COPY}}.
            A [code refactoring|https://github.com/MariaDB/server/commit/2dbeebdb16436e3c2723cd483aaf21d93de799d6] accidentally changed {{ALTER_COLUMN_OPTION}} and {{ALTER_COLUMN_STORAGE_TYPE}} to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.

            The impact of this bug should be incorrect operation of Mroonga when the column options GROONGA_TYPE, FLAGS are changed.

            InnoDB does not define any column options, only table options, so the flag {{ALTER_COLUMN_OPTION}} should never be set.

            analysis, fixing and testing

            marko Marko Mäkelä added a comment - analysis, fixing and testing
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2018-05-30 11:44:55.0 2018-05-30 11:44:55.044
            marko Marko Mäkelä made changes -
            Fix Version/s 10.3.8 [ 23113 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 87568 ] MariaDB v4 [ 154442 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.