A code refactoring accidentally changed ALTER_COLUMN_OPTION and ALTER_COLUMN_STORAGE_TYPE to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.
The impact of this bug should be incorrect operation of Mroonga when the column options GROONGA_TYPE, FLAGS are changed.
InnoDB does not define any column options, only table options, so the flag ALTER_COLUMN_OPTION should never be set.
blocks
MDEV-16328
ALTER TABLE…page_compression_level should not rebuild table
Closed
Marko Mäkelä
made changes -
2018-05-30 11:38
Component/s
Storage Engine - InnoDB
[ 10129
]
Marko Mäkelä
made changes -
2018-05-30 11:40
Description
A [code refactoring|https://github.com/MariaDB/server/commit/2dbeebdb16436e3c2723cd483aaf21d93de799d6 ] accidentally changed {{ALTER_COLUMN_OPTION}} and {{ALTER_COLUMN_STORAGE_TYPE}} to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.
The impact of this bug could be incorrect operation of Mroonga, and unnecessary use of {{ALGORITHM=COPY}} in InnoDB when the column options are changed.
For InnoDB, the impact seems to be that changing any of the InnoDB table options would only be allowed with {{ALGORITHM=COPY}}.
A [code refactoring|https://github.com/MariaDB/server/commit/2dbeebdb16436e3c2723cd483aaf21d93de799d6 ] accidentally changed {{ALTER_COLUMN_OPTION}} and {{ALTER_COLUMN_STORAGE_TYPE}} to be separate flags. InnoDB and Mroonga are only checking for the latter; the example storage engine is checking for the former only.
The impact of this bug should be incorrect operation of Mroonga when the column options GROONGA_TYPE, FLAGS are changed.
InnoDB does not define any column options, only table options, so the flag {{ALTER_COLUMN_OPTION}} should never be set.
Marko Mäkelä
made changes -
2018-05-30 11:44
issue.field.resolutiondate
2018-05-30 11:44:55.0
2018-05-30 11:44:55.044
Marko Mäkelä
made changes -
2018-05-30 11:44
Fix Version/s
10.3.8
[ 23113
]
Fix Version/s
10.3
[ 22126
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
Sergei Golubchik
made changes -
2021-12-06 21:47
Workflow
MariaDB v3
[ 87568
]
MariaDB v4
[ 154442
]
{"report":{"fcp":1498.5,"ttfb":762.6000000238419,"pageVisibility":"visible","entityId":67864,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"1bed6724-a1ab-4e3b-9e05-19a5f2296fe8","navigationType":0,"readyForUser":1606.699999988079,"redirectCount":0,"resourceLoadedEnd":1361.6000000238419,"resourceLoadedStart":771.3000000119209,"resourceTiming":[{"duration":173.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":771.3000000119209,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":771.3000000119209,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":945.1000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":173.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":771.6000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":771.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":945.4000000357628,"responseStart":0,"secureConnectionStart":0},{"duration":297.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":771.8000000119209,"connectEnd":771.8000000119209,"connectStart":771.8000000119209,"domainLookupEnd":771.8000000119209,"domainLookupStart":771.8000000119209,"fetchStart":771.8000000119209,"redirectEnd":0,"redirectStart":0,"requestStart":951.9000000357628,"responseEnd":1069.199999988079,"responseStart":965.4000000357628,"secureConnectionStart":771.8000000119209},{"duration":445.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":772.4000000357628,"connectEnd":772.4000000357628,"connectStart":772.4000000357628,"domainLookupEnd":772.4000000357628,"domainLookupStart":772.4000000357628,"fetchStart":772.4000000357628,"redirectEnd":0,"redirectStart":0,"requestStart":952.3000000119209,"responseEnd":1218.1000000238419,"responseStart":969.8000000119209,"secureConnectionStart":772.4000000357628},{"duration":196,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":772.6000000238419,"connectEnd":772.6000000238419,"connectStart":772.6000000238419,"domainLookupEnd":772.6000000238419,"domainLookupStart":772.6000000238419,"fetchStart":772.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":952.5,"responseEnd":968.6000000238419,"responseStart":967.6999999880791,"secureConnectionStart":772.6000000238419},{"duration":203.89999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":772.8000000119209,"connectEnd":772.8000000119209,"connectStart":772.8000000119209,"domainLookupEnd":772.8000000119209,"domainLookupStart":772.8000000119209,"fetchStart":772.8000000119209,"redirectEnd":0,"redirectStart":0,"requestStart":953.6000000238419,"responseEnd":976.6999999880791,"responseStart":974.9000000357628,"secureConnectionStart":772.8000000119209},{"duration":204.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":772.9000000357628,"connectEnd":772.9000000357628,"connectStart":772.9000000357628,"domainLookupEnd":772.9000000357628,"domainLookupStart":772.9000000357628,"fetchStart":772.9000000357628,"redirectEnd":0,"redirectStart":0,"requestStart":954.6999999880791,"responseEnd":977.1000000238419,"responseStart":975.5,"secureConnectionStart":772.9000000357628},{"duration":179.5999999642372,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":773.1000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":773.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":952.6999999880791,"responseStart":0,"secureConnectionStart":0},{"duration":206.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":773.3000000119209,"connectEnd":773.3000000119209,"connectStart":773.3000000119209,"domainLookupEnd":773.3000000119209,"domainLookupStart":773.3000000119209,"fetchStart":773.3000000119209,"redirectEnd":0,"redirectStart":0,"requestStart":958.4000000357628,"responseEnd":979.6000000238419,"responseStart":978.1999999880791,"secureConnectionStart":773.3000000119209},{"duration":181.0999999642372,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":773.4000000357628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":773.4000000357628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":954.5,"responseStart":0,"secureConnectionStart":0},{"duration":208.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":773.5,"connectEnd":773.5,"connectStart":773.5,"domainLookupEnd":773.5,"domainLookupStart":773.5,"fetchStart":773.5,"redirectEnd":0,"redirectStart":0,"requestStart":959.6999999880791,"responseEnd":981.8000000119209,"responseStart":980.1000000238419,"secureConnectionStart":773.5},{"duration":408.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":782.4000000357628,"connectEnd":782.4000000357628,"connectStart":782.4000000357628,"domainLookupEnd":782.4000000357628,"domainLookupStart":782.4000000357628,"fetchStart":782.4000000357628,"redirectEnd":0,"redirectStart":0,"requestStart":1153.5,"responseEnd":1190.800000011921,"responseStart":1188.5,"secureConnectionStart":782.4000000357628},{"duration":576.1999999880791,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":785.4000000357628,"connectEnd":785.4000000357628,"connectStart":785.4000000357628,"domainLookupEnd":785.4000000357628,"domainLookupStart":785.4000000357628,"fetchStart":785.4000000357628,"redirectEnd":0,"redirectStart":0,"requestStart":1348.800000011921,"responseEnd":1361.6000000238419,"responseStart":1361,"secureConnectionStart":785.4000000357628},{"duration":177.80000001192093,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1209.6000000238419,"connectEnd":1209.6000000238419,"connectStart":1209.6000000238419,"domainLookupEnd":1209.6000000238419,"domainLookupStart":1209.6000000238419,"fetchStart":1209.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1352.800000011921,"responseEnd":1387.4000000357628,"responseStart":1386.5,"secureConnectionStart":1209.6000000238419}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":578,"responseStart":762,"responseEnd":784,"domLoading":766,"domInteractive":1660,"domContentLoadedEventStart":1660,"domContentLoadedEventEnd":1707,"domComplete":2211,"loadEventStart":2211,"loadEventEnd":2211,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1637.4000000357628},{"name":"bigPipe.sidebar-id.end","time":1638.1000000238419},{"name":"bigPipe.activity-panel-pipe-id.start","time":1638.300000011921},{"name":"bigPipe.activity-panel-pipe-id.end","time":1641.1000000238419},{"name":"activityTabFullyLoaded","time":1727.699999988079}],"measures":[],"correlationId":"ec912b9518eb44","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":116,"dbReadsTimeInMs":18,"dbConnsTimeInMs":26,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
analysis, fixing and testing