Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15496

IPv6 literal addresses in wsrep SST scripts

Details

    Description

      SST joiner address parsing in wsrep_sst_common script no longer works with IPv6 address literals since MariaDB 10.2.13. It used to work in MariaDB 10.2.12.

      I seems problem was introduced in https://github.com/MariaDB/server/commit/e78e308e818a4a763ebb981302851f58f4c42bba.

      Based on the test case included in commit message it would seem author made an assumption that IPv6 address literals will not contain colon symbols. Unfortunately enough it is not true.

      Comparison of address parsing expressions:

      MariaDB 10.2.13

      (
      		 
        WSREP_SST_OPT_ADDR="[2001:db8::1]:4444/path";
      		 
        echo ${WSREP_SST_OPT_ADDR%%[:/]*};
      		 
      )
      		 
      // produces:
      		 
      // [2001

      MariaDB 10.2.12

      (
      		 
        WSREP_SST_OPT_ADDR="[2001:db8::1]:4444/path";
      		 
        echo ${WSREP_SST_OPT_ADDR/\]*/\]};
      		 
      )
      		 
      // produces:
      		 
      // [2001:db8::1]

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17618 Galera SST IPv6 problems

          • Major - Major loss of function.
          • Closed

          Activity

            danblack Daniel Black added a comment - - edited

            So sorry fln. Not so much as forgetting IPv6 has : just poor decisions and testing.

            Originally had the following then (poorly) decided to move this outside the IPv6 if condition and add : to remove the port onwards separator. This combined with a poor test case.

            ${WSREP_SST_OPT_ADDR%%\]*}

            Corrected per https://github.com/MariaDB/server/pull/644. Thanks for the bug report. Improved testing coming MDEV-15409.

            danblack Daniel Black added a comment - - edited So sorry fln . Not so much as forgetting IPv6 has : just poor decisions and testing. Originally had the following then (poorly) decided to move this outside the IPv6 if condition and add : to remove the port onwards separator. This combined with a poor test case. ${WSREP_SST_OPT_ADDR%%\]*} Corrected per https://github.com/MariaDB/server/pull/644 . Thanks for the bug report. Improved testing coming MDEV-15409 .

            People

              jplindst Jan Lindström (Inactive)
              fln Julius
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.