Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15091

Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data)

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 10.3.5
    • Compiling
    • None
    • 10.2.13

    Description

      When Windows warnings were recently fixed, C4267 was disabled (as noise). Recompiling recent 10.2 with this warning re-enabled produces 1981 warnings on Win64.

      (A lot of them come from spider, mysql_client_test, and connect). We should fix them, because they are important, actually one of the most important on Win64.

      Attachments

        Activity

          wlad Vladislav Vaintroub created issue -
          wlad Vladislav Vaintroub made changes -
          Field Original Value New Value
          Description When Windows warnings were recently fixed, C4267 was disabled (as noise). Recompiling recent 10.2 with this warning re-enabled produces 1981 warnings on Win64.

          (A lot of them come from spider, mysql_client_test, and connect)
          When Windows warnings were recently fixed, C4267 was disabled (as noise). Recompiling recent 10.2 with this warning re-enabled produces 1981 warnings on Win64.

          (A lot of them come from spider, mysql_client_test, and connect). We should fix them, because they are important, actually one of the most important on Win64.
          serg Sergei Golubchik made changes -
          Sprint 10.2.13 [ 228 ]
          wlad Vladislav Vaintroub made changes -
          Status Open [ 1 ] In Progress [ 3 ]

          Fixed in 10.3.
          externals plugins are excluded for now (spider, sphinx, connect, rocksdb)

          wlad Vladislav Vaintroub added a comment - Fixed in 10.3. externals plugins are excluded for now (spider, sphinx, connect, rocksdb)
          wlad Vladislav Vaintroub made changes -
          Component/s Compiling [ 11001 ]
          Fix Version/s 10.3.5 [ 22905 ]
          Fix Version/s 10.2 [ 14601 ]
          wlad Vladislav Vaintroub made changes -
          issue.field.resolutiondate 2018-02-06 13:56:16.0 2018-02-06 13:56:16.01
          wlad Vladislav Vaintroub made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 85167 ] MariaDB v4 [ 153661 ]

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.