Type:
Task
Priority:
Major
Resolution:
Fixed
These fixes mostly about re-arrangined code, like moving things out of mutex. No functional changes, no big patches.
commit 8389b45b7fa1a2ddab64050b0be3cdb3e1a937c1
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Mon Jan 22 23:58:52 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Moved mutex locking inside lock_rec_lock().
Moved monitor increment out of mutex.
Moved assertions that don't require protection out of mutex.
Removed duplicate assertions.
Moved duplicate debug injections into lock_rec_lock().
Let monitor updates use relaxed memory order.
Return directly without maintaining variables in lock_rec_lock_slow().
Moved lock_rec_lock_fast() body into lock_rec_lock(): saves at least one
trx_mutex_enter(), one switch() plus some code was moved out of mutex.
commit 04996939106bd35a2e8737de35a912ccc6b53ba4
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Tue Jan 23 13:23:35 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Moved lock_rec_lock_slow() inside lock_rec_lock().
commit 064bd78038ca8d76ca1612d849ccdcbbe4324110
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Wed Jan 24 22:10:16 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
When cloning oldest view, don't copy ReadView::m_creator_trx_id.
It means that the owner thread is now allowed to access this member
without trx_sys.mutex protection.
To achieve this we have to keep ReadView::m_creator_trx_id in
ReadView::m_ids. This is required to not let purge thread process
records owned by transaction associated with oldest view.
It is only required if trsanction entered read-write mode before it's
view was created.
If transaction entered read-write mode after it's view was created
(trx_set_rw_mode()), purge thread won't be allowed to touch it because
m_low_limit_id >= m_creator_trx_id holds. Thus we don't have to add
this transaction id to ReadView::m_ids.
Cleanups:
ReadView::ids_t: don't seem to make any sense, just complicate matters.
ReadView::copy_trx_ids(): doesn't make sense anymore, integrated into
caller.
ReadView::copy_complete(): not needed anymore.
ReadView copy constructores: don't seem to make any sense.
trx_purge_truncate_history(): removed view argument, access
purge_sys->view directly instead.
commit 55277e8840f359ed36a99359a7e21f03af72a78a
Author: Sergey Vojtovich <svoj@mariadb.org>
Date: Thu Jan 25 18:29:59 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Form better trx_sys API.
causes
MDEV-22680
InnoDB trx_sys improvements
Open
Sergey Vojtovich
made changes -
2018-01-24 16:33
Summary
Misc small scalability improvements that don't deserve distinct task
Misc small InnoDB scalability fixes
Sergey Vojtovich
made changes -
2018-01-24 16:34
Description
These fixes mostly about re-arrangined code, like moving things out of mutex. No functional changes, no big patches.
Sergey Vojtovich
made changes -
2018-01-26 06:54
Description
These fixes mostly about re-arrangined code, like moving things out of mutex. No functional changes, no big patches.
These fixes mostly about re-arrangined code, like moving things out of mutex. No functional changes, no big patches.
{noformat}
commit 8389b45b7fa1a2ddab64050b0be3cdb3e1a937c1
Author: Sergey Vojtovich <svoj@mariadb.org >
Date: Mon Jan 22 23:58:52 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Moved mutex locking inside lock_rec_lock().
Moved monitor increment out of mutex.
Moved assertions that don't require protection out of mutex.
Removed duplicate assertions.
Moved duplicate debug injections into lock_rec_lock().
Let monitor updates use relaxed memory order.
Return directly without maintaining variables in lock_rec_lock_slow().
Moved lock_rec_lock_fast() body into lock_rec_lock(): saves at least one
trx_mutex_enter(), one switch() plus some code was moved out of mutex.
commit 04996939106bd35a2e8737de35a912ccc6b53ba4
Author: Sergey Vojtovich <svoj@mariadb.org >
Date: Tue Jan 23 13:23:35 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Moved lock_rec_lock_slow() inside lock_rec_lock().
commit 064bd78038ca8d76ca1612d849ccdcbbe4324110
Author: Sergey Vojtovich <svoj@mariadb.org >
Date: Wed Jan 24 22:10:16 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
When cloning oldest view, don't copy ReadView::m_creator_trx_id.
It means that the owner thread is now allowed to access this member
without trx_sys.mutex protection.
To achieve this we have to keep ReadView::m_creator_trx_id in
ReadView::m_ids. This is required to not let purge thread process
records owned by transaction associated with oldest view.
It is only required if trsanction entered read-write mode before it's
view was created.
If transaction entered read-write mode after it's view was created
(trx_set_rw_mode()), purge thread won't be allowed to touch it because
m_low_limit_id >= m_creator_trx_id holds. Thus we don't have to add
this transaction id to ReadView::m_ids.
Cleanups:
ReadView::ids_t: don't seem to make any sense, just complicate matters.
ReadView::copy_trx_ids(): doesn't make sense anymore, integrated into
caller.
ReadView::copy_complete(): not needed anymore.
ReadView copy constructores: don't seem to make any sense.
trx_purge_truncate_history(): removed view argument, access
purge_sys->view directly instead.
commit 55277e8840f359ed36a99359a7e21f03af72a78a
Author: Sergey Vojtovich <svoj@mariadb.org >
Date: Thu Jan 25 18:29:59 2018 +0400
MDEV-15059 - Misc small InnoDB scalability fixes
Form better trx_sys API.
{noformat}
Sergey Vojtovich
made changes -
2018-03-21 06:50
Fix Version/s
10.3.5
[ 22905
]
Fix Version/s
10.3
[ 22126
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
Sergei Golubchik
made changes -
2021-12-06 21:23
Workflow
MariaDB v3
[ 85122
]
MariaDB v4
[ 133449
]
{"report":{"fcp":1262,"ttfb":229.29999995231628,"pageVisibility":"visible","entityId":65422,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":0.5,"journeyId":"9f4a67cc-b3ce-4850-8e48-b97a09db1a55","navigationType":0,"readyForUser":1348.8999998569489,"redirectCount":0,"resourceLoadedEnd":2177.0999999046326,"resourceLoadedStart":235.09999990463257,"resourceTiming":[{"duration":302.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":235.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":235.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":537.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":302.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":235.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":235.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":537.8999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":311.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":235.59999990463257,"connectEnd":235.59999990463257,"connectStart":235.59999990463257,"domainLookupEnd":235.59999990463257,"domainLookupStart":235.59999990463257,"fetchStart":235.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":235.59999990463257,"responseEnd":546.6999998092651,"responseStart":546.6999998092651,"secureConnectionStart":235.59999990463257},{"duration":423,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":235.79999995231628,"connectEnd":235.79999995231628,"connectStart":235.79999995231628,"domainLookupEnd":235.79999995231628,"domainLookupStart":235.79999995231628,"fetchStart":235.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":235.79999995231628,"responseEnd":658.7999999523163,"responseStart":658.7999999523163,"secureConnectionStart":235.79999995231628},{"duration":434.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":235.89999985694885,"connectEnd":235.89999985694885,"connectStart":235.89999985694885,"domainLookupEnd":235.89999985694885,"domainLookupStart":235.89999985694885,"fetchStart":235.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":235.89999985694885,"responseEnd":670.6999998092651,"responseStart":670.6999998092651,"secureConnectionStart":235.89999985694885},{"duration":436.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":236.5,"connectEnd":236.5,"connectStart":236.5,"domainLookupEnd":236.5,"domainLookupStart":236.5,"fetchStart":236.5,"redirectEnd":0,"redirectStart":0,"requestStart":236.5,"responseEnd":672.7999999523163,"responseStart":672.7999999523163,"secureConnectionStart":236.5},{"duration":437.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":236.69999980926514,"connectEnd":236.69999980926514,"connectStart":236.69999980926514,"domainLookupEnd":236.69999980926514,"domainLookupStart":236.69999980926514,"fetchStart":236.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":236.69999980926514,"responseEnd":674.1999998092651,"responseStart":674.1999998092651,"secureConnectionStart":236.69999980926514},{"duration":603.4000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":236.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":236.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":840.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":439.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":239.29999995231628,"connectEnd":239.29999995231628,"connectStart":239.29999995231628,"domainLookupEnd":239.29999995231628,"domainLookupStart":239.29999995231628,"fetchStart":239.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":239.29999995231628,"responseEnd":678.5999999046326,"responseStart":678.5999999046326,"secureConnectionStart":239.29999995231628},{"duration":601.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":239.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":239.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":840.8999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":440.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":239.79999995231628,"connectEnd":239.79999995231628,"connectStart":239.79999995231628,"domainLookupEnd":239.79999995231628,"domainLookupStart":239.79999995231628,"fetchStart":239.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":239.79999995231628,"responseEnd":680.5999999046326,"responseStart":680.5999999046326,"secureConnectionStart":239.79999995231628},{"duration":1195.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":240.79999995231628,"connectEnd":240.79999995231628,"connectStart":240.79999995231628,"domainLookupEnd":240.79999995231628,"domainLookupStart":240.79999995231628,"fetchStart":240.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":240.79999995231628,"responseEnd":1435.8999998569489,"responseStart":1435.8999998569489,"secureConnectionStart":240.79999995231628},{"duration":1936.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":240.79999995231628,"connectEnd":240.79999995231628,"connectStart":240.79999995231628,"domainLookupEnd":240.79999995231628,"domainLookupStart":240.79999995231628,"fetchStart":240.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":240.79999995231628,"responseEnd":2177.0999999046326,"responseStart":2177.0999999046326,"secureConnectionStart":240.79999995231628},{"duration":612.9000000953674,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":886.8999998569489,"connectEnd":886.8999998569489,"connectStart":886.8999998569489,"domainLookupEnd":886.8999998569489,"domainLookupStart":886.8999998569489,"fetchStart":886.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":886.8999998569489,"responseEnd":1499.7999999523163,"responseStart":1499.7999999523163,"secureConnectionStart":886.8999998569489},{"duration":962.7000000476837,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1242.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1242.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2205.2999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":42,"responseStart":229,"responseEnd":231,"domLoading":232,"domInteractive":2227,"domContentLoadedEventStart":2227,"domContentLoadedEventEnd":2284,"domComplete":3475,"loadEventStart":3475,"loadEventEnd":3476,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2181.899999856949},{"name":"bigPipe.sidebar-id.end","time":2182.699999809265},{"name":"bigPipe.activity-panel-pipe-id.start","time":2182.899999856949},{"name":"bigPipe.activity-panel-pipe-id.end","time":2185.0999999046326},{"name":"activityTabFullyLoaded","time":2298.399999856949}],"measures":[],"correlationId":"6e5ed410df7d20","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":116,"dbReadsTimeInMs":23,"dbConnsTimeInMs":34,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}