-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
These fixes mostly about re-arrangined code, like moving things out of mutex. No functional changes, no big patches.
commit 8389b45b7fa1a2ddab64050b0be3cdb3e1a937c1
|
Author: Sergey Vojtovich <svoj@mariadb.org>
|
Date: Mon Jan 22 23:58:52 2018 +0400
|
|
MDEV-15059 - Misc small InnoDB scalability fixes
|
|
Moved mutex locking inside lock_rec_lock().
|
Moved monitor increment out of mutex.
|
Moved assertions that don't require protection out of mutex.
|
Removed duplicate assertions.
|
Moved duplicate debug injections into lock_rec_lock().
|
Let monitor updates use relaxed memory order.
|
Return directly without maintaining variables in lock_rec_lock_slow().
|
Moved lock_rec_lock_fast() body into lock_rec_lock(): saves at least one
|
trx_mutex_enter(), one switch() plus some code was moved out of mutex.
|
|
commit 04996939106bd35a2e8737de35a912ccc6b53ba4
|
Author: Sergey Vojtovich <svoj@mariadb.org>
|
Date: Tue Jan 23 13:23:35 2018 +0400
|
|
MDEV-15059 - Misc small InnoDB scalability fixes
|
|
Moved lock_rec_lock_slow() inside lock_rec_lock().
|
|
commit 064bd78038ca8d76ca1612d849ccdcbbe4324110
|
Author: Sergey Vojtovich <svoj@mariadb.org>
|
Date: Wed Jan 24 22:10:16 2018 +0400
|
|
MDEV-15059 - Misc small InnoDB scalability fixes
|
|
When cloning oldest view, don't copy ReadView::m_creator_trx_id.
|
It means that the owner thread is now allowed to access this member
|
without trx_sys.mutex protection.
|
|
To achieve this we have to keep ReadView::m_creator_trx_id in
|
ReadView::m_ids. This is required to not let purge thread process
|
records owned by transaction associated with oldest view.
|
|
It is only required if trsanction entered read-write mode before it's
|
view was created.
|
|
If transaction entered read-write mode after it's view was created
|
(trx_set_rw_mode()), purge thread won't be allowed to touch it because
|
m_low_limit_id >= m_creator_trx_id holds. Thus we don't have to add
|
this transaction id to ReadView::m_ids.
|
|
Cleanups:
|
|
ReadView::ids_t: don't seem to make any sense, just complicate matters.
|
|
ReadView::copy_trx_ids(): doesn't make sense anymore, integrated into
|
caller.
|
|
ReadView::copy_complete(): not needed anymore.
|
|
ReadView copy constructores: don't seem to make any sense.
|
|
trx_purge_truncate_history(): removed view argument, access
|
purge_sys->view directly instead.
|
|
commit 55277e8840f359ed36a99359a7e21f03af72a78a
|
Author: Sergey Vojtovich <svoj@mariadb.org>
|
Date: Thu Jan 25 18:29:59 2018 +0400
|
|
MDEV-15059 - Misc small InnoDB scalability fixes
|
|
Form better trx_sys API.
|
- causes
-
MDEV-22680
InnoDB trx_sys improvements
-
-
Open
{"report":{"fcp":726.5,"ttfb":197.60000014305115,"pageVisibility":"visible","entityId":65422,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"5db31114-4970-4247-b3ae-8b8a69f8f099","navigationType":0,"readyForUser":869.9000000953674,"redirectCount":0,"resourceLoadedEnd":903.7000000476837,"resourceLoadedStart":203.40000009536743,"resourceTiming":[{"duration":7.700000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":203.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":203.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":211.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":7.700000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":203.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":203.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":211.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":61.299999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":203.90000009536743,"connectEnd":203.90000009536743,"connectStart":203.90000009536743,"domainLookupEnd":203.90000009536743,"domainLookupStart":203.90000009536743,"fetchStart":203.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":203.90000009536743,"responseEnd":265.2000000476837,"responseStart":265.2000000476837,"secureConnectionStart":203.90000009536743},{"duration":132.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":204.10000014305115,"connectEnd":204.10000014305115,"connectStart":204.10000014305115,"domainLookupEnd":204.10000014305115,"domainLookupStart":204.10000014305115,"fetchStart":204.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":204.10000014305115,"responseEnd":337,"responseStart":337,"secureConnectionStart":204.10000014305115},{"duration":137.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":204.30000019073486,"connectEnd":204.30000019073486,"connectStart":204.30000019073486,"domainLookupEnd":204.30000019073486,"domainLookupStart":204.30000019073486,"fetchStart":204.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":204.30000019073486,"responseEnd":341.40000009536743,"responseStart":341.40000009536743,"secureConnectionStart":204.30000019073486},{"duration":137.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":204.5,"connectEnd":204.5,"connectStart":204.5,"domainLookupEnd":204.5,"domainLookupStart":204.5,"fetchStart":204.5,"redirectEnd":0,"redirectStart":0,"requestStart":204.5,"responseEnd":342,"responseStart":342,"secureConnectionStart":204.5},{"duration":137.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":204.70000004768372,"connectEnd":204.70000004768372,"connectStart":204.70000004768372,"domainLookupEnd":204.70000004768372,"domainLookupStart":204.70000004768372,"fetchStart":204.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":204.70000004768372,"responseEnd":342.30000019073486,"responseStart":342.30000019073486,"secureConnectionStart":204.70000004768372},{"duration":204.29999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":204.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":204.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":409.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":137.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":205,"connectEnd":205,"connectStart":205,"domainLookupEnd":205,"domainLookupStart":205,"fetchStart":205,"redirectEnd":0,"redirectStart":0,"requestStart":205,"responseEnd":342.80000019073486,"responseStart":342.80000019073486,"secureConnectionStart":205},{"duration":204.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":205.20000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":205.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":409.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":138.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":205.30000019073486,"connectEnd":205.30000019073486,"connectStart":205.30000019073486,"domainLookupEnd":205.30000019073486,"domainLookupStart":205.30000019073486,"fetchStart":205.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":205.30000019073486,"responseEnd":343.40000009536743,"responseStart":343.30000019073486,"secureConnectionStart":205.30000019073486},{"duration":470.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":206.30000019073486,"connectEnd":206.30000019073486,"connectStart":206.30000019073486,"domainLookupEnd":206.30000019073486,"domainLookupStart":206.30000019073486,"fetchStart":206.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":206.30000019073486,"responseEnd":676.4000000953674,"responseStart":676.4000000953674,"secureConnectionStart":206.30000019073486},{"duration":506.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":206.40000009536743,"connectEnd":206.40000009536743,"connectStart":206.40000009536743,"domainLookupEnd":206.40000009536743,"domainLookupStart":206.40000009536743,"fetchStart":206.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":206.40000009536743,"responseEnd":713.2000000476837,"responseStart":713.2000000476837,"secureConnectionStart":206.40000009536743},{"duration":255.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":421,"connectEnd":421,"connectStart":421,"domainLookupEnd":421,"domainLookupStart":421,"fetchStart":421,"redirectEnd":0,"redirectStart":0,"requestStart":421,"responseEnd":676.9000000953674,"responseStart":676.9000000953674,"secureConnectionStart":421},{"duration":191,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":719.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":719.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":910.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":161.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":741.8000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":741.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":903.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":64.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":742.8000001907349,"connectEnd":742.8000001907349,"connectStart":742.8000001907349,"domainLookupEnd":742.8000001907349,"domainLookupStart":742.8000001907349,"fetchStart":742.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":742.8000001907349,"responseEnd":807.6000001430511,"responseStart":807.6000001430511,"secureConnectionStart":742.8000001907349},{"duration":108.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":743.3000001907349,"connectEnd":743.3000001907349,"connectStart":743.3000001907349,"domainLookupEnd":743.3000001907349,"domainLookupStart":743.3000001907349,"fetchStart":743.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":743.3000001907349,"responseEnd":851.5,"responseStart":851.5,"secureConnectionStart":743.3000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":44,"responseStart":197,"responseEnd":199,"domLoading":201,"domInteractive":942,"domContentLoadedEventStart":942,"domContentLoadedEventEnd":989,"domComplete":1067,"loadEventStart":1067,"loadEventEnd":1068,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":913.8000001907349},{"name":"bigPipe.sidebar-id.end","time":914.6000001430511},{"name":"bigPipe.activity-panel-pipe-id.start","time":914.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":915.6000001430511},{"name":"activityTabFullyLoaded","time":1004.3000001907349}],"measures":[],"correlationId":"c18a680487ec08","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":87,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Closing since the project is over.