Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14537

TokuDB not recognized for compilation

Details

    Description

      Hello, I tried to pack the new 10.2.11 into Fedora.

      Everything's fine but TokuDB, which won't compile anymore.
      The Cmake won't recognize it as usable: "Performing Test TOKUDB_OK - Failed"

      I think the issue lies within this commit: 7f1900705b
      https://github.com/MariaDB/server/commit/7f1900705b
      Within file "storage/tokudb/CMakeLists.txt"

      The new code there is:

      # tokudb requires F_NOCACHE, O_DIRECT, and designated initializers
      CHECK_CXX_SOURCE_COMPILES(
      "
      #include <fcntl.h>
      struct a {int b; int c; };
      struct a d = { .b=1, .c=2 };
      int main() { return F_NOCACHE + O_DIRECT; }
      " TOKUDB_OK)
      

      While the 'O_DIRECT' can be set

       The O_DIRECT, O_NOATIME, O_PATH, and  O_TMPFILE  flags  are  Linux-speā€cific. One must define _GNU_SOURCE to obtain their definitions
      

      The 'F_NOCACHE' is Darwin Kernel (Mac OS X) specific and not present in Fedora.

      Attachments

        Issue Links

          Activity

            mschorm Michal Schorm created issue -

            Yes, we're fixing the source and releasing missing packages.

            As a workaround you can specify -DTOKUDB_OK=1 in a .spec file.

            serg Sergei Golubchik added a comment - Yes, we're fixing the source and releasing missing packages. As a workaround you can specify -DTOKUDB_OK=1 in a .spec file.
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            mschorm Michal Schorm added a comment -

            Added "-DTOKUDB_OK=1" as a Cmake argument, eneded up with "lto1: internal compiler error: Segmentation fault".

            Probabbly not something you should take care of , just informing. (In case more people would hit it)
            I'll try to look into it.

            mschorm Michal Schorm added a comment - Added "-DTOKUDB_OK=1" as a Cmake argument, eneded up with "lto1: internal compiler error: Segmentation fault". Probabbly not something you should take care of , just informing. (In case more people would hit it) I'll try to look into it.
            elenst Elena Stepanova made changes -
            Fix Version/s 10.2 [ 14601 ]
            Assignee Sergei Golubchik [ serg ]
            mschorm Michal Schorm added a comment -

            The compiler error meantioned in previous comment is most likely some Fedora Rawhide issue.
            On released Fedora 27 it builds fine when using your workaround.

            mschorm Michal Schorm added a comment - The compiler error meantioned in previous comment is most likely some Fedora Rawhide issue. On released Fedora 27 it builds fine when using your workaround.
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2.11 [ 22634 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 84207 ] MariaDB v4 [ 153271 ]

            People

              serg Sergei Golubchik
              mschorm Michal Schorm
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.