Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14529

InnoDB rw-locks: optimize memory barriers

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.3.2
    • 10.3.3
    • Server
    • None
    • Ubuntu 16.02 on Arm 64 bit platform

    Description

      Hi,

      I see __atomic_compare_exchange_n function is being called with different memory order while
      doing the same type of atomic operation. In spin lock ACQUIRE AND RELAX being used

      but in rw_lock_lock_word_decr function

      i see __ATOMIC_SEQ_CST being hard coded in the cmpxchng. I feel we can use consistenly use ACQUIRE AND RELAX memory order for all the mutex implemenation in all the platform.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-14442 Optimization for ARM64 platform.

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            ssethia Sandeep sethia created issue -
            ssethia Sandeep sethia made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            Fix Version/s 10.3 [ 22126 ]
            Assignee Sergey Vojtovich [ svoj ]
            svoj Sergey Vojtovich made changes -
            Epic Link MDEV-14442 [ 64369 ]
            ssethia Sandeep sethia made changes -
            Attachment memory_order.patch [ 44705 ]
            svoj Sergey Vojtovich made changes -
            Summary Code refactoring : __atomic_compare_exchange_n InnoDB rw-locks: optimize memory barriers
            svoj Sergey Vojtovich made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            svoj Sergey Vojtovich made changes -
            Assignee Sergey Vojtovich [ svoj ] Marko Mäkelä [ marko ]
            Status Confirmed [ 10101 ] In Review [ 10002 ]
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Sergey Vojtovich [ svoj ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            svoj Sergey Vojtovich made changes -
            Fix Version/s 10.3.3 [ 22644 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 84158 ] MariaDB v4 [ 153264 ]

            People

              svoj Sergey Vojtovich
              ssethia Sandeep sethia
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.