Fixing the potential corruption bug MDEV-14310 will reduce the performance of ALTER TABLE when the operation fails or is interrupted.
There is no reason to write pages that would be freed as part of rolling back the operation.
Maybe there should be a separate flush list for the pages for which redo logging has been disabled. Then the FlushObserver could simply leave buf_pool_t::flush_list alone.
- relates to
-
MDEV-14310
Possible corruption by table-rebuilding or index-creating ALTER TABLE…ALGORITHM=INPLACE
-
-
Closed
{"report":{"fcp":766.0999999046326,"ttfb":115.39999997615814,"pageVisibility":"visible","entityId":64175,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"2d8e571e-6aa5-402f-8ad6-ff929b692f05","navigationType":0,"readyForUser":814,"redirectCount":0,"resourceLoadedEnd":802.5,"resourceLoadedStart":121.19999992847443,"resourceTiming":[{"duration":183.39999997615814,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":121.19999992847443,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":121.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":304.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":183.19999992847443,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":121.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":121.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":304.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":192.19999992847443,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":121.5,"connectEnd":121.5,"connectStart":121.5,"domainLookupEnd":121.5,"domainLookupStart":121.5,"fetchStart":121.5,"redirectEnd":0,"redirectStart":0,"requestStart":121.5,"responseEnd":313.6999999284744,"responseStart":313.6999999284744,"secureConnectionStart":121.5},{"duration":266.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":121.59999990463257,"connectEnd":121.59999990463257,"connectStart":121.59999990463257,"domainLookupEnd":121.59999990463257,"domainLookupStart":121.59999990463257,"fetchStart":121.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":121.59999990463257,"responseEnd":388.2999999523163,"responseStart":388.1999999284744,"secureConnectionStart":121.59999990463257},{"duration":270.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":121.69999992847443,"connectEnd":121.69999992847443,"connectStart":121.69999992847443,"domainLookupEnd":121.69999992847443,"domainLookupStart":121.69999992847443,"fetchStart":121.69999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":121.69999992847443,"responseEnd":392.09999990463257,"responseStart":392.09999990463257,"secureConnectionStart":121.69999992847443},{"duration":271.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":121.79999995231628,"connectEnd":121.79999995231628,"connectStart":121.79999995231628,"domainLookupEnd":121.79999995231628,"domainLookupStart":121.79999995231628,"fetchStart":121.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":121.79999995231628,"responseEnd":393.09999990463257,"responseStart":393.09999990463257,"secureConnectionStart":121.79999995231628},{"duration":272.10000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":121.89999997615814,"connectEnd":121.89999997615814,"connectStart":121.89999997615814,"domainLookupEnd":121.89999997615814,"domainLookupStart":121.89999997615814,"fetchStart":121.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":121.89999997615814,"responseEnd":394,"responseStart":394,"secureConnectionStart":121.89999997615814},{"duration":272.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":122,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":122,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":394.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":272.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":122.19999992847443,"connectEnd":122.19999992847443,"connectStart":122.19999992847443,"domainLookupEnd":122.19999992847443,"domainLookupStart":122.19999992847443,"fetchStart":122.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":122.19999992847443,"responseEnd":394.7999999523163,"responseStart":394.7999999523163,"secureConnectionStart":122.19999992847443},{"duration":273.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":122.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":122.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":395.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":273.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":122.39999997615814,"connectEnd":122.39999997615814,"connectStart":122.39999997615814,"domainLookupEnd":122.39999997615814,"domainLookupStart":122.39999997615814,"fetchStart":122.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":122.39999997615814,"responseEnd":395.6999999284744,"responseStart":395.6999999284744,"secureConnectionStart":122.39999997615814},{"duration":367.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":123.19999992847443,"connectEnd":123.19999992847443,"connectStart":123.19999992847443,"domainLookupEnd":123.19999992847443,"domainLookupStart":123.19999992847443,"fetchStart":123.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":123.19999992847443,"responseEnd":490.7999999523163,"responseStart":490.7999999523163,"secureConnectionStart":123.19999992847443},{"duration":679.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":123.29999995231628,"connectEnd":123.29999995231628,"connectStart":123.29999995231628,"domainLookupEnd":123.29999995231628,"domainLookupStart":123.29999995231628,"fetchStart":123.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":123.29999995231628,"responseEnd":802.5,"responseStart":802.5,"secureConnectionStart":123.29999995231628},{"duration":275.2000000476837,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":525.5999999046326,"connectEnd":525.5999999046326,"connectStart":525.5999999046326,"domainLookupEnd":525.5999999046326,"domainLookupStart":525.5999999046326,"fetchStart":525.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":525.5999999046326,"responseEnd":800.7999999523163,"responseStart":800.7999999523163,"secureConnectionStart":525.5999999046326}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":9,"responseStart":115,"responseEnd":117,"domLoading":118,"domInteractive":866,"domContentLoadedEventStart":866,"domContentLoadedEventEnd":900,"domComplete":1637,"loadEventStart":1637,"loadEventEnd":1638,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":850.2999999523163},{"name":"bigPipe.sidebar-id.end","time":851.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":851.1999999284744},{"name":"bigPipe.activity-panel-pipe-id.end","time":853.6999999284744},{"name":"activityTabFullyLoaded","time":908.2999999523163}],"measures":[],"correlationId":"8ef3f2dd5139dd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":59,"dbReadsTimeInMs":8,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Major