Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14172

mariabackup doesn't store innodb_fast_checksum (removed variable) in backup-my.cnf when taking backup of 5.5

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Won't Fix
    • 10.1(EOL), 10.2(EOL)
    • N/A
    • Backup
    • None

    Description

      see test bug733651.sh for ways to reproduce

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-14936 Test MariaDB Backup 10.1 against newest versions of 5.5 and 10.0

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            anikitin Andrii Nikitin (Inactive) created issue -
            anikitin Andrii Nikitin (Inactive) made changes -
            Field Original Value New Value
            wlad Vladislav Vaintroub added a comment -

            What would be the purpose of this variable in backup-my.cnf?
            it is read by mariabackup that does not understand it because it was removed.

            wlad Vladislav Vaintroub added a comment - What would be the purpose of this variable in backup-my.cnf? it is read by mariabackup that does not understand it because it was removed.
            wlad Vladislav Vaintroub made changes -
            Fix Version/s N/A [ 14700 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Won't Fix [ 2 ]
            Status Open [ 1 ] Closed [ 6 ]
            anikitin Andrii Nikitin (Inactive) added a comment -

            I am really not sure what these questions try to address.
            I will just consider that they assume that mariabackup will not be used to backup 5.5 ; thus leaving them without answer.

            anikitin Andrii Nikitin (Inactive) added a comment - I am really not sure what these questions try to address. I will just consider that they assume that mariabackup will not be used to backup 5.5 ; thus leaving them without answer.
            wlad Vladislav Vaintroub added a comment -

            Maybe you should explain why do you think it is a bug, and what is the expected behavior of --prepare if backup-my.cnf has this parameter

            wlad Vladislav Vaintroub added a comment - Maybe you should explain why do you think it is a bug, and what is the expected behavior of --prepare if backup-my.cnf has this parameter
            anikitin Andrii Nikitin (Inactive) added a comment -

            I don't know expected behavior, but it quite obvious that problem will happen if backup is attempted on instance with innodb_fast_checksum enabled.
            I assigned this to an engineer to prioritize and investigate possible outcome.

            anikitin Andrii Nikitin (Inactive) added a comment - I don't know expected behavior, but it quite obvious that problem will happen if backup is attempted on instance with innodb_fast_checksum enabled. I assigned this to an engineer to prioritize and investigate possible outcome.
            wlad Vladislav Vaintroub added a comment -

            The real problem is not the content of backup-my.cnf, but the fact that fast checksum code was removed. This apparently did not bother anyone during the upgrade, there is no mentioning of the upgrade procedure in our documentation, and I cannot find a single bug report re MariaDB upgrade and fast checksums. So overall, this feature was probably not used much and it does not make sense to implement any workarounds, but rather document the limitation .

            wlad Vladislav Vaintroub added a comment - The real problem is not the content of backup-my.cnf, but the fact that fast checksum code was removed. This apparently did not bother anyone during the upgrade, there is no mentioning of the upgrade procedure in our documentation, and I cannot find a single bug report re MariaDB upgrade and fast checksums. So overall, this feature was probably not used much and it does not make sense to implement any workarounds, but rather document the limitation .
            anikitin Andrii Nikitin (Inactive) added a comment -

            The aim is to have expected behavior for all input configuration. I agree that you mention valid points, but not sure why you mentioned them.

            anikitin Andrii Nikitin (Inactive) added a comment - The aim is to have expected behavior for all input configuration. I agree that you mention valid points, but not sure why you mentioned them.
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 83199 ] MariaDB v4 [ 153054 ]

            People

              wlad Vladislav Vaintroub
              anikitin Andrii Nikitin (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.