[MDEV-13637] InnoDB change buffer housekeeping can cause redo log overrun and possibly deadlocks - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL)
Fix Version/s: 10.0.33, 10.1.27, 10.2.9, 10.3.2
Component/s: Storage Engine - InnoDB
Labels:
- crash
- create_table
- deadlock
- recovery

Description

As reported in ~~MDEV-13485~~, the function ibuf_remove_free_page() may be called while the caller is holding several mutexes or rw-locks. Because of this, this housekeeping loop may cause performance glitches for operations that involve tables that are stored in the InnoDB system tablespace. Deadlocks are also theoretically possible.

The worst impact of all is that due to the mutexes being held, calls to log_free_check() must be skipped during this housekeeping. This means that the cyclic InnoDB redo log may be overwritten. If the system crashes during this, it would be unable to recover.

The entry point to the problematic code is ibuf_free_excess_pages(). It would make sense to call it before acquiring any mutexes or rw-locks, in any DDL operation and in any 'pessimistic' operation that involves the system tablespace.

Attachments

Issue Links

relates to

MDEV-25267 Reported latching order violation in ibuf_remove_free_page()

Closed

MDEV-29905 Change buffer operations fail to check for log file overflow

Closed

MDEV-11634 Improve the InnoDB change buffer

Closed

MDEV-13485 MTR tests fail massively with --innodb-sync-debug

Closed

MDEV-14643 InnoDB: Failing assertion: !cursor->index->is_committed()

Closed

Activity

Ascending order - Click to sort in descending order

Marko Mäkelä added a comment - 2017-08-24 13:03

bb-10.2-marko
I intend to backport this to 10.0 as well.

Marko Mäkelä added a comment - 2017-08-24 13:03 bb-10.2-marko I intend to backport this to 10.0 as well.

Marko Mäkelä added a comment - 2017-08-24 13:31

For the record, I cannot repeat the equivalent of the 10.2 test in 10.0:

./mtr --mysqld=--loose-innodb-sync-debug --mem --noreorder innodb_zip.innodb-zip,4k,innodb innodb_zip.wl5522_debug_zip,4k,innodb innodb_zip.wl5522_zip,4k,innodb

./mtr --mysqld=--innodb-page-size=4k --mysqld=--loose-innodb-sync-debug --mem --noreorder innodb_zip.innodb-zip innodb.innodb-wl5522-debug-zip innodb.innodb-wl5522-zip

The reason is that only innodb_zip.innodb-zip in 10.0 allows the innodb_page_size=4k combination.

Marko Mäkelä added a comment - 2017-08-24 13:31 For the record, I cannot repeat the equivalent of the 10.2 test in 10.0: ./mtr --mysqld=--loose-innodb-sync-debug --mem --noreorder innodb_zip.innodb-zip,4k,innodb innodb_zip.wl5522_debug_zip,4k,innodb innodb_zip.wl5522_zip,4k,innodb ./mtr --mysqld=--innodb-page-size=4k --mysqld=--loose-innodb-sync-debug --mem --noreorder innodb_zip.innodb-zip innodb.innodb-wl5522-debug-zip innodb.innodb-wl5522-zip The reason is that only innodb_zip.innodb-zip in 10.0 allows the innodb_page_size=4k combination.

Marko Mäkelä added a comment - 2017-08-24 13:38

bb-10.0-marko

Marko Mäkelä added a comment - 2017-08-24 13:38 bb-10.0-marko

Jan Lindström (Inactive) added a comment - 2017-08-25 10:47

10.0 ok to push, 10.2 can you try to avoid unnecessary code duplication.

Jan Lindström (Inactive) added a comment - 2017-08-25 10:47 10.0 ok to push, 10.2 can you try to avoid unnecessary code duplication.

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2017-08-24 11:48

Updated:: 2022-10-28 06:59

Resolved:: 2017-08-28 12:12

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server