Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
make install used to install these symlinks:
lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mtr -> ./mysql-test-run.pl
|
lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mysql-test-run -> ./mysql-test-run.pl
|
After c872b10022180602fbd5b2b0310b6d1e343dff5a they are not installed anymore.
commit c872b10022180602fbd5b2b0310b6d1e343dff5a
|
Author: Sergei Golubchik
|
Date: Wed Aug 9 18:23:04 2017 +0200
|
|
|
don't install same files twice
|
|
CMakeLists.txt - merge mistake, apparently
|
|
include/CMakeLists.txt - install from CMAKE_CURRENT_BINARY_DIR.
|
Only install from CMAKE_CURRENT_SOURCE_DIR, if it's different
|
from CMAKE_CURRENT_BINARY_DIR
|
|
mysql-test/CMakeLists.txt - INSTALL_MYSQL_TEST() macro installs
|
everything, no need to install mtr separately once again
|
|
mysql-test/lib/My/SafeProcess/CMakeLists.txt
|
MYSQL_ADD_EXECUTABLE includes INSTALL
|
|
sql-bench/CMakeLists.txt
|
list files explicitly. don't install garbage, don't process 'foo'
|
and 'foo.sh' separately, it's only one file to install, not two.
|
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
We used to install these symlinks:
{noformat} lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mtr -> ./mysql-test-run.pl lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mysql-test-run -> ./mysql-test-run.pl {noformat} After c872b10022180602fbd5b2b0310b6d1e343dff5a they are not installed anymore. {noformat} commit c872b10022180602fbd5b2b0310b6d1e343dff5a Author: Sergei Golubchik Date: Wed Aug 9 18:23:04 2017 +0200 don't install same files twice CMakeLists.txt - merge mistake, apparently include/CMakeLists.txt - install from CMAKE_CURRENT_BINARY_DIR. Only install from CMAKE_CURRENT_SOURCE_DIR, if it's different from CMAKE_CURRENT_BINARY_DIR mysql-test/CMakeLists.txt - INSTALL_MYSQL_TEST() macro installs everything, no need to install mtr separately once again mysql-test/lib/My/SafeProcess/CMakeLists.txt MYSQL_ADD_EXECUTABLE includes INSTALL sql-bench/CMakeLists.txt list files explicitly. don't install garbage, don't process 'foo' and 'foo.sh' separately, it's only one file to install, not two. {noformat} |
{{make install}} used to install these symlinks:
{noformat} lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mtr -> ./mysql-test-run.pl lrwxrwxrwx 1 elenst elenst 19 Aug 15 00:55 /data/bld/10.2/mysql-test/mysql-test-run -> ./mysql-test-run.pl {noformat} After c872b10022180602fbd5b2b0310b6d1e343dff5a they are not installed anymore. {noformat} commit c872b10022180602fbd5b2b0310b6d1e343dff5a Author: Sergei Golubchik Date: Wed Aug 9 18:23:04 2017 +0200 don't install same files twice CMakeLists.txt - merge mistake, apparently include/CMakeLists.txt - install from CMAKE_CURRENT_BINARY_DIR. Only install from CMAKE_CURRENT_SOURCE_DIR, if it's different from CMAKE_CURRENT_BINARY_DIR mysql-test/CMakeLists.txt - INSTALL_MYSQL_TEST() macro installs everything, no need to install mtr separately once again mysql-test/lib/My/SafeProcess/CMakeLists.txt MYSQL_ADD_EXECUTABLE includes INSTALL sql-bench/CMakeLists.txt list files explicitly. don't install garbage, don't process 'foo' and 'foo.sh' separately, it's only one file to install, not two. {noformat} |
| Affects Version/s | 10.2 [ 14601 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.2.8 [ 22544 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 82078 ] | MariaDB v4 [ 152618 ] |