Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13106

Installer complains that directory is not empty

Details

    Description

      Hello,
      when I choose an empty DB folder during installation, the installer complains that it is not empty.
      I took a look at the sources and maybe there is an error.
      https://github.com/atcurtis/mariadb/blob/master/win/packaging/ca/CustomAction.cpp#L181
      Line 181 checks the filename for . or ..
      wcscmp returns 0 if the strings are equal (which is interpreted as "false").
      This means the if statement is true, if the name is not equal . or not equal ..
      This expression is always true becaue every name is not equal . or not equal ..
      The operator should be && instead of ||

      Regards,
      Thomas

      Attachments

        Activity

          ThomasHoffmann Thomas Hoffmann created issue -
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          Component/s Platform Windows [ 10138 ]
          Fix Version/s 10.2 [ 14601 ]
          Assignee Vladislav Vaintroub [ wlad ]
          wlad Vladislav Vaintroub made changes -
          Fix Version/s 10.1.25 [ 22542 ]
          Fix Version/s 10.2 [ 14601 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 81267 ] MariaDB v4 [ 152341 ]

          People

            wlad Vladislav Vaintroub
            ThomasHoffmann Thomas Hoffmann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.