[MDEV-13002] mysqltest regex replace results in incorrect result - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.2.6, 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL)
Fix Version/s: 10.1.25, 5.5.57, 10.0.32, 10.2.7
Component/s: Scripts & Clients, Tests
Labels:
None

Description

From https://travis-ci.org/MariaDB/server/jobs/238967452

As seen with the : plugins.server_audit and plugins.thread_pool_server_audit tests

Setting a large hostname like travis (testing-docker-99f46c25-f6c4-4465-bc49-ee78d188e37c) is sufficient to trigger test. A smaller test hostname of
testing-docker-99f46c25 passes.

The regexs are right using [^,]* as the host match which should match the hostname. Though it escapes for ',' I don't think escaping is needed (and it doesn't affect result removing escapes).

related to c91ecf9e9bebf3cf2dafbd3193de4df94be09870 ?

Testable locally by changing hostname to a name above with hostname command.

];mtr: spent 0:01:23 on 237 tests. 0:02:04 (356 tests) leftplugins.server_audit                     w4 [ fail ]

        Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.result	2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.reject	2017-06-03 01:45:43.814546287 +0000

@@ -368,7 +368,7 @@

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'  \'',0

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

-TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

+20170603 01:45:43,testing-docker-de343aff-a28e-4fe6-a1e4-4b97f4f3d0c3,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SHOW WARNINGS',0

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

 TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show variables like \'server_audit%\'',0

mysqltest: Result length mismatch

 - saving '/home/travis/build/MariaDB/server/mysql-test/var/4/log/plugins.server_audit/' to '/home/travis/build/MariaDB/server/mysql-test/var/log/plugins.server_audit/'

];mtr: spent 0:01:24 on 239 tests. 0:02:04 (354 tests) leftplugins.thread_pool_server_audit         w2 [ fail ]

        Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.thread_pool_server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.result	2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.reject	2017-06-03 01:45:43.754546287 +0000

Attachments

Activity

Ascending order - Click to sort in descending order

Daniel Black created issue - 2017-06-06 07:15

Sergei Golubchik made changes - 2017-06-06 09:00

Field	Original Value	New Value
Affects Version/s		10.2.6 [ 22527 ]
Affects Version/s	10.2.7 [ 22543 ]

Daniel Black made changes - 2017-06-08 04:31

Description

From https://travis-ci.org/MariaDB/server/jobs/238967452

As seen with the : plugins.server_audit and plugins.thread_pool_server_audit tests

Setting a large hostname like travis (testing-docker-99f46c25-f6c4-4465-bc49-ee78d188e37c) is sufficient to trigger test. A smaller test hostname of
testing-docker-99f46c25 passes.

The regexs are right using [^,]* as the host match which should match the hostname. Thought escapes for , I don't think are needed.

related to c91ecf9e9bebf3cf2dafbd3193de4df94be09870 ?

{noformat}
];mtr: spent 0:01:23 on 237 tests. 0:02:04 (356 tests) leftplugins.server_audit w4 [ fail ]

Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.result 2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.reject 2017-06-03 01:45:43.814546287 +0000

@@ -368,7 +368,7 @@

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\' \'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

-TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

+20170603 01:45:43,testing-docker-de343aff-a28e-4fe6-a1e4-4b97f4f3d0c3,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SHOW WARNINGS',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show variables like \'server_audit%\'',0

mysqltest: Result length mismatch

- saving '/home/travis/build/MariaDB/server/mysql-test/var/4/log/plugins.server_audit/' to '/home/travis/build/MariaDB/server/mysql-test/var/log/plugins.server_audit/'

];mtr: spent 0:01:24 on 239 tests. 0:02:04 (354 tests) leftplugins.thread_pool_server_audit w2 [ fail ]

Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.thread_pool_server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.result 2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.reject 2017-06-03 01:45:43.754546287 +0000
{noformat}

From https://travis-ci.org/MariaDB/server/jobs/238967452

As seen with the : plugins.server_audit and plugins.thread_pool_server_audit tests

Setting a large hostname like travis (testing-docker-99f46c25-f6c4-4465-bc49-ee78d188e37c) is sufficient to trigger test. A smaller test hostname of
testing-docker-99f46c25 passes.

The regexs are right using [^,]* as the host match which should match the hostname. Though it escapes for ',' I don't think escaping is needed (and it doesn't affect result removing escapes).

related to c91ecf9e9bebf3cf2dafbd3193de4df94be09870 ?

Testable locally by changing hostname to a name above with hostname command.

{noformat}
];mtr: spent 0:01:23 on 237 tests. 0:02:04 (356 tests) leftplugins.server_audit w4 [ fail ]

Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.result 2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/server_audit.reject 2017-06-03 01:45:43.814546287 +0000

@@ -368,7 +368,7 @@

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\' \'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

-TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

+20170603 01:45:43,testing-docker-de343aff-a28e-4fe6-a1e4-4b97f4f3d0c3,root,localhost,ID,ID,QUERY,sa_db,'set global server_audit_file_path=\'nonexisting_dir/\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SHOW WARNINGS',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show status like \'server_audit_current_log\'',0

TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'show variables like \'server_audit%\'',0

mysqltest: Result length mismatch

- saving '/home/travis/build/MariaDB/server/mysql-test/var/4/log/plugins.server_audit/' to '/home/travis/build/MariaDB/server/mysql-test/var/log/plugins.server_audit/'

];mtr: spent 0:01:24 on 239 tests. 0:02:04 (354 tests) leftplugins.thread_pool_server_audit w2 [ fail ]

Test ended at 2017-06-03 01:45:44

CURRENT_TEST: plugins.thread_pool_server_audit

--- /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.result 2017-06-03 01:12:33.602546287 +0000

+++ /home/travis/build/MariaDB/server/mysql-test/suite/plugins/r/thread_pool_server_audit.reject 2017-06-03 01:45:43.754546287 +0000
{noformat}

Elena Stepanova made changes - 2017-06-11 22:05

Status

Open [ 1 ]

Confirmed [ 10101 ]

Elena Stepanova made changes - 2017-06-11 22:12

Fix Version/s		5.5 [ 15800 ]
Fix Version/s		10.0 [ 16000 ]
Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.2 [ 14601 ]
Affects Version/s		5.5 [ 15800 ]
Affects Version/s		10.0 [ 16000 ]
Affects Version/s		10.1 [ 16100 ]
Affects Version/s		10.2 [ 14601 ]
Assignee		Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2017-06-15 12:42

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2017-06-15 12:42

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Sergei Golubchik made changes - 2017-06-19 12:18

Fix Version/s		5.5.57 [ 22539 ]
Fix Version/s		10.0.32 [ 22504 ]
Fix Version/s		10.1.25 [ 22542 ]
Fix Version/s		10.2.7 [ 22543 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	5.5 [ 15800 ]
Fix Version/s	10.0 [ 16000 ]
Fix Version/s	10.1 [ 16100 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:45

Workflow

MariaDB v3 [ 81107 ]

MariaDB v4 [ 152273 ]

People

Assignee:: Sergei Golubchik

Reporter:: Daniel Black

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2017-06-06 07:15

Updated:: 2017-06-29 04:57

Resolved:: 2017-06-19 12:18

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Activity

People

Dates

Git Integration