[MDEV-12938] Discrepancy between mysql_config and mariadb_config - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.2.6
Fix Version/s: 10.2.7
Component/s: Scripts & Clients
Labels:
None
Environment:
macOS 10.12.5, Homebrew

Description

Hello!

There is a discrepancy between the link options provided by mysql_config and mariadb_config. Please see the relevant outputs (options --libs and --libs_r) below.

I would expect for mysql_config to also output the missing link libraries. Otherwise it is breaking out-of-the-box compatibility to MySQL as one is required to add the missing link dependencies by hand.

$ mariadb_config

Copyright 2011-2015 MariaDB Corporation AB

Get compiler flags for using the MariaDB Connector/C.

Usage: mariadb_config [OPTIONS]

  --cflags        [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql]

  --include       [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql]

  --libs          [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib]

  --libs_r        [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib]

  --libs_sys      [-lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib]

  --version       [10.2.5]

  --socket        [/tmp/mysql.sock]

  --port          [3306]

  --plugindir     [/usr/local/Cellar/mariadb/10.2.6/lib/plugin]

  --tlsinfo       [OpenSSL 1.0.2k]

$ mysql_config

Usage: /usr/local/bin/mysql_config [OPTIONS]

Options:

        --cflags         [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/.. ]

        --include        [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/..]

        --libs           [-L/usr/local/Cellar/mariadb/10.2.6/lib  -lmariadb]

        --libs_r         [-L/usr/local/Cellar/mariadb/10.2.6/lib  -lmariadb]

        --plugindir      [/usr/local/Cellar/mariadb/10.2.6/lib/plugin]

        --socket         [/tmp/mysql.sock]

        --port           [0]

        --version        [10.2.6]

        --libmysqld-libs [-L/usr/local/Cellar/mariadb/10.2.6/lib  -lmysqld]

        --variable=VAR   VAR is one of:

                pkgincludedir [/usr/local/Cellar/mariadb/10.2.6/include/mysql]

                pkglibdir     [/usr/local/Cellar/mariadb/10.2.6/lib]

                plugindir     [/usr/local/Cellar/mariadb/10.2.6/lib/plugin]

Thank you.

Attachments

Activity

Ascending order - Click to sort in descending order

Dan created issue - 2017-05-28 16:11

Dan made changes - 2017-05-28 16:37

Field	Original Value	New Value
Description	Hello! There is a discrepancy between the link options provided by mysql_config and mariadb_config. Please see the relevant outputs (options --link and --link_r) below. I would expect for mysql_config to also output the missing link libraries. Otherwise it is breaking out-of-the-box compatibility to MySQL as one is required to add the missing link dependencies by hand. {code} $ mariadb_config Copyright 2011-2015 MariaDB Corporation AB Get compiler flags for using the MariaDB Connector/C. Usage: mariadb_config [OPTIONS] --cflags [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql] --include [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql] --libs [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --libs_r [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --libs_sys [-lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --version [10.2.5] --socket [/tmp/mysql.sock] --port [3306] --plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] --tlsinfo [OpenSSL 1.0.2k] {code} {code} $ mysql_config Usage: /usr/local/bin/mysql_config [OPTIONS] Options: --cflags [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/.. ] --include [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/..] --libs [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmariadb] --libs_r [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmariadb] --plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] --socket [/tmp/mysql.sock] --port [0] --version [10.2.6] --libmysqld-libs [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmysqld] --variable=VAR VAR is one of: pkgincludedir [/usr/local/Cellar/mariadb/10.2.6/include/mysql] pkglibdir [/usr/local/Cellar/mariadb/10.2.6/lib] plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] {code} Thank you.	Hello! There is a discrepancy between the link options provided by mysql_config and mariadb_config. Please see the relevant outputs (options --libs and --libs_r) below. I would expect for mysql_config to also output the missing link libraries. Otherwise it is breaking out-of-the-box compatibility to MySQL as one is required to add the missing link dependencies by hand. {code} $ mariadb_config Copyright 2011-2015 MariaDB Corporation AB Get compiler flags for using the MariaDB Connector/C. Usage: mariadb_config [OPTIONS] --cflags [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql] --include [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/mysql] --libs [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --libs_r [-L/usr/local/Cellar/mariadb/10.2.6/lib/ -lmariadb -lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --libs_sys [-lpthread -ldl -lm -l/usr/lib/libiconv.dylib -l/usr/local/opt/openssl/lib/libssl.dylib -l/usr/local/opt/openssl/lib/libcrypto.dylib /usr/lib/libiconv.dylib] --version [10.2.5] --socket [/tmp/mysql.sock] --port [3306] --plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] --tlsinfo [OpenSSL 1.0.2k] {code} {code} $ mysql_config Usage: /usr/local/bin/mysql_config [OPTIONS] Options: --cflags [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/.. ] --include [-I/usr/local/Cellar/mariadb/10.2.6/include/mysql -I/usr/local/Cellar/mariadb/10.2.6/include/mysql/..] --libs [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmariadb] --libs_r [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmariadb] --plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] --socket [/tmp/mysql.sock] --port [0] --version [10.2.6] --libmysqld-libs [-L/usr/local/Cellar/mariadb/10.2.6/lib -lmysqld] --variable=VAR VAR is one of: pkgincludedir [/usr/local/Cellar/mariadb/10.2.6/include/mysql] pkglibdir [/usr/local/Cellar/mariadb/10.2.6/lib] plugindir [/usr/local/Cellar/mariadb/10.2.6/lib/plugin] {code} Thank you.

Sergei Golubchik made changes - 2017-05-30 11:47

Fix Version/s

10.2 [ 14601 ]

Sergei Golubchik made changes - 2017-05-30 11:48

Assignee

Sergei Golubchik [ serg ]

Sergei Golubchik added a comment - 2017-05-30 11:49

georg, wlad, why do we still distribute mysql_config in the first place?

Sergei Golubchik added a comment - 2017-05-30 11:49 georg , wlad , why do we still distribute mysql_config in the first place?

Vladislav Vaintroub added a comment - 2017-05-30 13:08

serg, I think it widely used to detect MySQL or MariaDB installations, in 3rd parties builds. I see no mistake in mysql_config . I'm wondering what we install mariadb_config for. Nothing depends on it. it is a question whether mariadb_config makes a good replacement for mysql_config yet. I think the library paths are hardcoded in mariadb_config, and if this is so, zip or tar.gz packages would no more be relocatable

Vladislav Vaintroub added a comment - 2017-05-30 13:08 serg , I think it widely used to detect MySQL or MariaDB installations, in 3rd parties builds. I see no mistake in mysql_config . I'm wondering what we install mariadb_config for. Nothing depends on it. it is a question whether mariadb_config makes a good replacement for mysql_config yet. I think the library paths are hardcoded in mariadb_config, and if this is so, zip or tar.gz packages would no more be relocatable

Sergei Golubchik made changes - 2017-06-28 17:41

Status

Open [ 1 ]

In Progress [ 3 ]

Sergei Golubchik added a comment - 2017-06-29 11:17

Generally, I'd say that such a script belongs to the client library code, so it should be part of libmariadb/.
But mysql_config is a widely used name, so ideally, I'd say, C/C should install mariadb_config and symlink it to mysql_config, just as it's doing with libmariadb.so -> libmysqlclient.so.

But in this particular case, C/C knows nothing about embedded, so mariadb_config cannot possibly have --libmysqld-libs flag. So, I'd say, we don't install mariadb_config, only mysql_config. And symlink it to mariadb_config.

Sergei Golubchik added a comment - 2017-06-29 11:17 Generally, I'd say that such a script belongs to the client library code, so it should be part of libmariadb/. But mysql_config is a widely used name, so ideally, I'd say, C/C should install mariadb_config and symlink it to mysql_config , just as it's doing with libmariadb.so -> libmysqlclient.so . But in this particular case, C/C knows nothing about embedded, so mariadb_config cannot possibly have --libmysqld-libs flag. So, I'd say, we don't install mariadb_config , only mysql_config . And symlink it to mariadb_config .

Vladislav Vaintroub added a comment - 2017-06-29 11:30 - edited

do we need mariadb_config at all? as symlink. Who would need it?

Vladislav Vaintroub added a comment - 2017-06-29 11:30 - edited do we need mariadb_config at all? as symlink. Who would need it?

Sergei Golubchik added a comment - 2017-06-29 11:58

I thought that when we implement MDEV-9295, then we could switch to using mariadb_config and mysql_config will be a symlink to it.

and it's kind of expected to have xxx_config script for a library libxxx.so.

Sergei Golubchik added a comment - 2017-06-29 11:58 I thought that when we implement MDEV-9295 , then we could switch to using mariadb_config and mysql_config will be a symlink to it. and it's kind of expected to have xxx_config script for a library libxxx.so.

Sergei Golubchik made changes - 2017-06-29 17:22

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Sergei Golubchik added a comment - 2017-07-05 15:20

mysql_config --libs now lists all libraries

Sergei Golubchik added a comment - 2017-07-05 15:20 mysql_config --libs now lists all libraries

Sergei Golubchik made changes - 2017-07-05 15:20

Component/s		Scripts & Clients [ 11002 ]
Fix Version/s		10.2.7 [ 22543 ]
Fix Version/s	10.2 [ 14601 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:45

Workflow

MariaDB v3 [ 80983 ]

MariaDB v4 [ 152237 ]

People

Assignee:: Sergei Golubchik

Reporter:: Dan

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2017-05-28 16:11

Updated:: 2017-07-05 15:20

Resolved:: 2017-07-05 15:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server