Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12794

innodb_zip.recover failed in buildbot

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2.6
    • 10.2.7
    • Tests
    • None

    Description

      http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-quantal-x86/builds/7100/steps/test/logs/stdio

      innodb_zip.recover 'innodb'              w4 [ fail ]  Found warnings/errors in server log file!
      		 
              Test ended at 2017-05-11 18:35:21
      		 
      line
      		 
      2017-05-11 18:35:19 3057604352 [ERROR] mysqld: Table './mysql/plugin' is marked as crashed and should be repaired
      		 
      2017-05-11 18:35:19 3057604352 [ERROR] mysqld: Table 'plugin' is marked as crashed and should be repaired
      		 
      2017-05-11 18:35:19 3057604352 [Warning] Checking table:   './mysql/plugin'
      		 
      2017-05-11 18:35:19 3057604352 [ERROR] mysql.plugin: 1 client is using or hasn't closed the table properly

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12720 recovery fails with "Generic error" for ROW_FORMAT=compressed

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova created issue -
            marko Marko Mäkelä added a comment -

            This test is not writing to any other than InnoDB tables. No call to mtr.add_suppression(), only a server kill+restart.
            Maybe this should be fixed somewhere in the mtr infrastructure? If that is not acceptable, then I think that adding
            FLUSH TABLES to the start of the test should do the trick.

            marko Marko Mäkelä added a comment - This test is not writing to any other than InnoDB tables. No call to mtr.add_suppression(), only a server kill+restart. Maybe this should be fixed somewhere in the mtr infrastructure? If that is not acceptable, then I think that adding FLUSH TABLES to the start of the test should do the trick.
            elenst Elena Stepanova added a comment -

            I don't think it would be right to suppress an error like that globally, it can hide too many potential problems.
            We could consider adding FLUSH directly to include/restart_mysqld.inc, particularly if shutdown_timeout=0.
            One problem that I can think of right away is that if restart_mysqld.inc is called concurrently with some workflow (on purpose, to test a specific scenario), FLUSH would totally change the dynamics.
            Alternatively, we could add a parameter to restart_mysqld.inc, but then it might be just easier to do FLUSH directly in the test.
            Maybe there can be other and better ideas, let's think about it for a while.

            elenst Elena Stepanova added a comment - I don't think it would be right to suppress an error like that globally, it can hide too many potential problems. We could consider adding FLUSH directly to include/restart_mysqld.inc , particularly if shutdown_timeout=0 . One problem that I can think of right away is that if restart_mysqld.inc is called concurrently with some workflow (on purpose, to test a specific scenario), FLUSH would totally change the dynamics. Alternatively, we could add a parameter to restart_mysqld.inc , but then it might be just easier to do FLUSH directly in the test. Maybe there can be other and better ideas, let's think about it for a while.
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä added a comment -

            I added the FLUSH TABLES statement to the test, because that indeed seems to be the best option.

            marko Marko Mäkelä added a comment - I added the FLUSH TABLES statement to the test, because that indeed seems to be the best option.
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2.7 [ 22543 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            Affects Version/s 10.2.6 [ 22527 ]
            Affects Version/s 10.2 [ 14601 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 80760 ] MariaDB v4 [ 152150 ]

            People

              marko Marko Mäkelä
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.