Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12771

Remove Item_func_xxx::decimal_precision() for case and abbreviations

Details

    Description

      decimal_precision() implementations for the classes implementing CASE and CASE-alike functions became redundant after implementing MDEV-12770. The derived implementation from Item should perfectly do the job (by going through Type_handler_xxx::type_handler().

      We'll remove decimal_precision() from the following classes:

      Item_func_ifnull
      		 
      Item_func_case_abbreviation2
      		 
      Item_func_if
      		 
      Item_func_nvl2
      		 
      Item_func_nullif
      		 
      Item_func_case

      This will reduce the amount of duplicate code.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          bar Alexander Barkov created issue -
          bar Alexander Barkov made changes -
          Field Original Value New Value
          Description {{decimal_precision()}} implementations for the classes implementing CASE and CASE-alike functions became redundant after implementing {{MDEV-12770}}. The derived implementation from {{Item}} should perfectly do the job (by going through {{Type_handler_xxx::type_handler()}}.

          We'll remove {{decimal_precision()}} from the following classes:
          {code:cpp}
          Item_func_ifnull
          Item_func_case_abbreviation2
          Item_func_if
          Item_func_nvl2
          Item_func_nullif
          Item_func_case
          {code}
          		{{decimal_precision()}} implementations for the classes implementing CASE and CASE-alike functions became redundant after implementing {{MDEV-12770}}. The derived implementation from {{Item}} should perfectly do the job (by going through {{Type_handler_xxx::type_handler()}}.

          We'll remove {{decimal_precision()}} from the following classes:
          {code:cpp}
          Item_func_ifnull
          Item_func_case_abbreviation2
          Item_func_if
          Item_func_nvl2
          Item_func_nullif
          Item_func_case
          {code}
          This will reduce the amount of duplicate code.
          bar Alexander Barkov made changes -
          Labels datatype refactoring
          bar Alexander Barkov added a comment -

          Pushed to bb-10.2-ext

          bar Alexander Barkov added a comment - Pushed to bb-10.2-ext
          bar Alexander Barkov made changes -
          issue.field.resolutiondate 2017-05-10 05:27:48.0 2017-05-10 05:27:48.812
          bar Alexander Barkov made changes -
          Fix Version/s 10.3.1 [ 22532 ]
          Fix Version/s 10.3 [ 22126 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 80707 ] MariaDB v4 [ 133248 ]

          People

            bar Alexander Barkov
            bar Alexander Barkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.