marko, I appreciate your effort fixing this bug. But this task was created to reference issue found during column compression implementation, which I worked around by disabling INPLACE for compressed columns.

Original goal of this task was to support INPLACE for compressed columns.

I understand that it revealed another more serious issue, which was also worked around by disabling INPLACE for non-const DEFAULT.

But now we have no open task neither for compressed columns nor for non-const DEFAULT to support INPLACE.

I think it is not fair.

ok to push after test is repeatable.

bb-10.2-marko

The fix to MDEV-8392 needs some refinement.

In ADD COLUMN as well as when changing a NULL column to NOT NULL, we must currently reject ALGORITHM=INPLACE when the DEFAULT expression is not a constant.

I believe there're 2 different issues:

• with non-constant default values we get NULL when we subsequently query this data
• with compressed columns we get buffer filled with 0x8F (presumably after TRASH_FREE)

I think that we need a quick solution before the 10.2 GA release: simply refuse ALGORITHM=INPLACE if there are any non-constant DEFAULT values for added columns.

Fixing this is somewhat tricky, because InnoDB would need to convert each row to MySQL format for evaluating the non-constant default values. Currently InnoDB uses a ‘default record’ of constant values that it will substitute for added columns.
When fixing this properly, we could at the same time relax some restrictions that MySQL 5.7 introduced for ALTER TABLE…LOCK=NONE when indexed virtual columns exist.

The issue is not only with compressed fields, but with any fields that has a default that is not constant

Here is an example for this:

create or replace table t1 (a int auto_increment primary key, b int) engine=myisam;
insert into t1 values (1,1),(2,2);
ALTER TABLE t1 ADD COLUMN c int default b;
select * from t1;

Innodb result is:
-----------

-----------

-----------

While MYISAM gives the right result:
-----------

-----------

-----------

The problem is that InnoDB only calls set_default() only once, when it should call it for every row for fields with "field->default_value" set.

For the record:
ALTER TABLE…ALGORITHM=INPLACE only deals with TABLE::record[] for reporting duplicate key errors. The function innobase_rec_reset() is related to that (reset those columns to NULL for which we do not know the values).
When a table is being rebuilt online, data stored off-page is copied from the old copy of the table. When creating secondary indexes on column prefixes, the necessary prefix of BLOB columns will be written to the sort buffers and online_log and ultimately be inserted into the index.