Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10142 PL/SQL parser
  3. MDEV-12392

Duplicate code cleanup: add function normalize_db_name()

    XMLWordPrintable

Details

    Description

      There is a duplicate code in sql_db.cc, in functions mysql_create_db_internal() and mysql_rm_db_internal().

      char db_tmp[SAFE_NAME_LEN], *dbnorm;
      if (lower_case_table_names)
      {
        strmake_buf(db_tmp, db);
        my_casedn_str(system_charset_info, db_tmp);
        dbnorm= db_tmp;
      }
      else
        dbnorm= db;
      

      Will introduce a new function normalize_db_name() and reuse it.

      This change was originally a part of MDEV-11952, but it was decided to commit it as a standalone change.

      Attachments

        Issue Links

          Activity

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1h
                  1h

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.