Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11602

InnoDB leaks foreign key metadata on DDL operations

Details

    Description

      A memory leak was introduced in MDEV-6759 to address a ‘valgrind failure’ which looks like a double free when running ./mtr main.alter_table. Here is a simple test case that will trigger LeakSanitizer when building 10.1 with cmake -DWITH_ASAN=ON:

      --source include/have_innodb.inc
      CREATE TABLE t1 (id INT PRIMARY KEY) ENGINE=INNODB;
      CREATE TABLE t2 (id INT PRIMARY KEY, t1_id INT, FOREIGN KEY (t1_id) REFERENCES t1(id)) ENGINE=INNODB;
      DROP TABLE t2,t1;
      

      With a fix in place, these memory leaks are gone, but there are some others. In 10.1.21, all of --suite=innodb,innodb_fts,innodb_zip,encryption completed fine. So did main.alter_table. Tests for --suite=main are still running.

      I will test 10.0 too to see if a double free in main.alter_table can be observed there.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Affects Version/s 10.2.0 [ 20700 ]
            Affects Version/s 10.1.2 [ 15801 ]
            Affects Version/s 10.0.15 [ 17300 ]
            Affects Version/s 10.1.21 [ 22113 ]
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Jan Lindström [ jplindst ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            jplindst Jan Lindström (Inactive) made changes -
            Assignee Jan Lindström [ jplindst ] Marko Mäkelä [ marko ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            marko Marko Mäkelä made changes -
            Fix Version/s 10.0.29 [ 22312 ]
            Fix Version/s 10.1.21 [ 22113 ]
            Fix Version/s 10.2.3 [ 22115 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 78816 ] MariaDB v4 [ 151401 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.