Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11016

wsrep_node_is_ready() check is too strict

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 5.5-galera, 10.1(EOL)
    • 10.1.21
    • wsrep
    • None

    Description

      The check that prints the dreaded "WSREP has not yet prepared node for application use" is sometimes too strict. It doesn't allow any selects, even if these selects do not access any tables. For example, I'd think that

      SELECT 1;
      

      or, for example,

      SELECT @@max_allowed_packet;
      

      could be allowed. This is easy to do, one should not report this error if all_tables is NULL.

      Attachments

        Issue Links

          Activity

            serg Sergei Golubchik created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Description The check that prints the dreaded "WSREP has not yet prepared node for application use" is sometimes too strict. It doesn't allow any selects, even if these selects do not access any tables. For example, I'd think that
            {code:sql}
            SELECT 1;
            {code}
            or, for example,
            {code:sql}
            SELECT @@max_allowed_packet;
            {code}
            could be allowed. This is easy to do, one need to report this error if {{all_tables}} is not NULL.
            The check that prints the dreaded "WSREP has not yet prepared node for application use" is sometimes too strict. It doesn't allow any selects, even if these selects do not access any tables. For example, I'd think that
            {code:sql}
            SELECT 1;
            {code}
            or, for example,
            {code:sql}
            SELECT @@max_allowed_packet;
            {code}
            could be allowed. This is easy to do, one should not report this error if {{all_tables}} is NULL.
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Assignee Nirbhay Choubey [ nirbhay_c ] Sachin Setiya [ sachin.setiya.007 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Assignee Sachin Setiya [ sachin.setiya.007 ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Assignee Sergei Golubchik [ serg ] Sachin Setiya [ sachin.setiya.007 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Assignee Sachin Setiya [ sachin.setiya.007 ] Sergei Golubchik [ serg ]

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Sachin Setiya [ sachin.setiya.007 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            issue.field.resolutiondate 2016-12-01 16:14:47.0 2016-12-01 16:14:47.297
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Fix Version/s 5.5.54 [ 22307 ]
            Fix Version/s 10.0.29-galera [ 22405 ]
            Fix Version/s 10.1.19 [ 22111 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 5.5-galera [ 21900 ]
            Fix Version/s 10.0-galera [ 21901 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]

            Reopening because of the failing galera.MW-284 test, which could be linked to the commit.

            nirbhay_c Nirbhay Choubey (Inactive) added a comment - Reopening because of the failing galera.MW-284 test, which could be linked to the commit.
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Stalled [ 10000 ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Priority Major [ 3 ] Blocker [ 1 ]

            Patch Reverted.

            sachin.setiya.007 Sachin Setiya (Inactive) added a comment - Patch Reverted.
            dbart Daniel Bartholomew made changes -
            Fix Version/s 5.5.54-galera [ 22404 ]
            Fix Version/s 5.5.54 [ 22307 ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1.19 [ 22111 ]
            Fix Version/s 5.5.54-galera [ 22404 ]
            Fix Version/s 10.0.29-galera [ 22405 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Assignee Sachin Setiya [ sachin.setiya.007 ] Nirbhay Choubey [ nirbhay_c ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Assignee Nirbhay Choubey [ nirbhay_c ] Sachin Setiya [ sachin.setiya.007 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sachin.setiya.007 Sachin Setiya (Inactive) made changes -
            Fix Version/s 10.1.21 [ 22113 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Affects Version/s 10.0-galera [ 21901 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 77743 ] MariaDB v4 [ 151048 ]

            People

              sachin.setiya.007 Sachin Setiya (Inactive)
              serg Sergei Golubchik
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.