Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-10982

Faking the server version also changes version number logged to error log

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2(EOL)
    • 10.2.3
    • OTHER
    • None
    • 10.2.4-1

    Description

      Setting a fake version string does not only change what version number clients see, but also what server version is printed to the error log.

      This should either show the real version, or both the "real" and "faked" version.

      Otherwise things can become really confusing when trying to analyse error logs ...

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-10967 Print the real version in the error log #2

          • Major - Major loss of function.
          • Closed
          is caused by

          Task - A task that needs to be done. MDEV-7780 Support for faking server version

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link 10.2 pull request

          Activity

            Ascending order - Click to sort in descending order
            hholzgra Hartmut Holzgraefe created issue -
            hholzgra Hartmut Holzgraefe made changes -
            Field Original Value New Value
            hholzgra Hartmut Holzgraefe added a comment - - edited

            I have 

            [mysqld]
            		 
            version=1.2.3

            in my.cnf and the startup messages in the error log look like this:

            It is actually correct at the beginning of the startup messages:

            161008 13:09:06 mysqld_safe Starting mysqld daemon with databases from /usr/local/mariadb-git-hartmut-MDEV-10541/var
            		 
            2016-10-08 13:09:06 140571076974784 [Note] /usr/local/mariadb-git-hartmut-MDEV-10541/bin/mysqld (mysqld 10.2.3-MariaDB as 1.2.3) starting as process 7174 ...

            but not at the end when the server actually becomes ready:

            2016-10-08 13:09:06 140571076974784 [Note] /usr/local/mariadb-git-hartmut-MDEV-10541/bin/mysqld: ready for connections.
            		 
            Version: '1.2.3'  socket: '/tmp/mysql.sock'  port: 3306  Source distribution

            hholzgra Hartmut Holzgraefe added a comment - - edited I have [mysqld] version=1.2.3 in my.cnf and the startup messages in the error log look like this: It is actually correct at the beginning of the startup messages: 161008 13:09:06 mysqld_safe Starting mysqld daemon with databases from /usr/local/mariadb-git-hartmut-MDEV-10541/var 2016-10-08 13:09:06 140571076974784 [Note] /usr/local/mariadb-git-hartmut-MDEV-10541/bin/mysqld (mysqld 10.2.3-MariaDB as 1.2.3) starting as process 7174 ... but not at the end when the server actually becomes ready: 2016-10-08 13:09:06 140571076974784 [Note] /usr/local/mariadb-git-hartmut-MDEV-10541/bin/mysqld: ready for connections. Version: '1.2.3' socket: '/tmp/mysql.sock' port: 3306 Source distribution
            hholzgra Hartmut Holzgraefe made changes -
            svoj Sergey Vojtovich made changes -
            svoj Sergey Vojtovich made changes -
            Assignee Sergey Vojtovich [ svoj ]
            svoj Sergey Vojtovich made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            svoj Sergey Vojtovich made changes -
            Fix Version/s 10.2 [ 14601 ]
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.2.4-1 [ 110 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked higher
            svoj Sergey Vojtovich made changes -
            Component/s OTHER [ 10125 ]
            Fix Version/s 10.2.3 [ 22115 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            diego dupin Diego Dupin added a comment - - edited

            using 10.2.4 version, using "version=10.2.4-diego" in my.ini ,
            driver still receive the "fake" version "5.5.5-" prefix. (driver in my example receive "5.5.5-10.2.4-diego")

            diego dupin Diego Dupin added a comment - - edited using 10.2.4 version, using "version=10.2.4-diego" in my.ini , driver still receive the "fake" version "5.5.5-" prefix. (driver in my example receive "5.5.5-10.2.4-diego")
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 77706 ] MariaDB v4 [ 151025 ]

            People

              svoj Sergey Vojtovich
              hholzgra Hartmut Holzgraefe
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.