Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9711 NO PAD collations
  3. MDEV-10742

LDML: make conf_to_src reuse common data between collations

Details

    • Technical task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 10.2.2
    • Character Sets
    • None
    • 10.2.2-3, 10.2.2-2

    Description

      conf_to_src duplicates the ctype, to_lower, to_upper and tab_to_uni arrays when dumping data from the XML files in /sql/share/charsets/ to ctype-extra.c

      For example, the ctype map from cp1251.xml is dumped five times:

      static const uchar ctype_cp1251_bulgarian_ci[] = ..
      static const uchar ctype_cp1251_ukrainian_ci[] = ..
      static const uchar ctype_cp1251_bin[] = ..
      static const uchar ctype_cp1251_general_ci[] = ..
      static const uchar ctype_cp1251_general_cs[] = ..
      

      After adding MDEV-9711 the number of duplicate data will grow even further two times.

      We'll change conf_to_src.c to detect duplicate arrays. Non-primary collations will reuse arrays from the primary collation if the data is the same.

      Attachments

        Issue Links

          Activity

            There are no comments yet on this issue.

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.