Type:
Technical task
Priority:
Major
Resolution:
Fixed
Affects Version/s:
None
Sprint:
10.2.2-3, 10.2.2-2
conf_to_src duplicates the ctype , to_lower , to_upper and tab_to_uni arrays when dumping data from the XML files in /sql/share/charsets/ to ctype-extra.c
For example, the ctype map from cp1251.xml is dumped five times:
static const uchar ctype_cp1251_bulgarian_ci[] = ..
static const uchar ctype_cp1251_ukrainian_ci[] = ..
static const uchar ctype_cp1251_bin[] = ..
static const uchar ctype_cp1251_general_ci[] = ..
static const uchar ctype_cp1251_general_cs[] = ..
After adding MDEV-9711 the number of duplicate data will grow even further two times.
We'll change conf_to_src.c to detect duplicate arrays. Non-primary collations will reuse arrays from the primary collation if the data is the same.
Alexander Barkov
made changes -
2016-09-05 06:02
Description
{{conf_to_src}} duplicates the {{ctype}}, {{to_lower}}, {{to_upper}} and {{tab_to_uni}} arrays when dumping data from the XML files in /sql/share/charsets/ to {{ctype-extra.c}}
For example, the {{ctype}} map from {{cp1251.xml}} is dumped five times:
{code:c}
static const uchar ctype_cp1251_bulgarian_ci[] = ..
static const uchar ctype_cp1251_ukrainian_ci[] = ..
static const uchar ctype_cp1251_bin[] = ..
static const uchar ctype_cp1251_general_ci[] = ..
static const uchar ctype_cp1251_general_cs[] = ..
{code}
After adding MDEV-9711 the number of duplicate data will grow even further two times.
We'll change {{conf_to_src.c}} to detect duplicate arrays. Non-primary collations will reuse arrays from the primary collation if the data is the same.
{{conf_to_src}} duplicates the {{ctype}}, {{to_lower}}, {{to_upper}} and {{tab_to_uni}} arrays when dumping data from the XML files in {{/sql/share/charsets/}} to {{ctype-extra.c}}
For example, the {{ctype}} map from {{cp1251.xml}} is dumped five times:
{code:c}
static const uchar ctype_cp1251_bulgarian_ci[] = ..
static const uchar ctype_cp1251_ukrainian_ci[] = ..
static const uchar ctype_cp1251_bin[] = ..
static const uchar ctype_cp1251_general_ci[] = ..
static const uchar ctype_cp1251_general_cs[] = ..
{code}
After adding MDEV-9711 the number of duplicate data will grow even further two times.
We'll change {{conf_to_src.c}} to detect duplicate arrays. Non-primary collations will reuse arrays from the primary collation if the data is the same.
Alexander Barkov
made changes -
2016-09-05 07:33
Fix Version/s
10.2.2
[ 22013
]
Fix Version/s
10.2
[ 14601
]
Resolution
Fixed
[ 1
]
Status
Open
[ 1
]
Closed
[ 6
]
Sergei Golubchik
made changes -
2021-12-06 21:43
Workflow
MariaDB v3
[ 76910
]
MariaDB v4
[ 150870
]
{"report":{"fcp":969.5999999046326,"ttfb":307.89999985694885,"pageVisibility":"visible","entityId":57905,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"cf0f3b80-e77b-4dce-9ed4-67451ef44c09","navigationType":0,"readyForUser":1048.7000000476837,"redirectCount":0,"resourceLoadedEnd":1647.5,"resourceLoadedStart":314.09999990463257,"resourceTiming":[{"duration":123.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":314.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":314.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":437.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":123.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":314.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":314.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":437.89999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":188.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":314.7000000476837,"connectEnd":314.7000000476837,"connectStart":314.7000000476837,"domainLookupEnd":314.7000000476837,"domainLookupStart":314.7000000476837,"fetchStart":314.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":314.7000000476837,"responseEnd":503.59999990463257,"responseStart":503.59999990463257,"secureConnectionStart":314.7000000476837},{"duration":283.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":314.7999999523163,"connectEnd":314.7999999523163,"connectStart":314.7999999523163,"domainLookupEnd":314.7999999523163,"domainLookupStart":314.7999999523163,"fetchStart":314.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":314.7999999523163,"responseEnd":598.5999999046326,"responseStart":598.5999999046326,"secureConnectionStart":314.7999999523163},{"duration":287.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":315.09999990463257,"connectEnd":315.09999990463257,"connectStart":315.09999990463257,"domainLookupEnd":315.09999990463257,"domainLookupStart":315.09999990463257,"fetchStart":315.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":315.09999990463257,"responseEnd":602.7999999523163,"responseStart":602.7999999523163,"secureConnectionStart":315.09999990463257},{"duration":288,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":315.2000000476837,"connectEnd":315.2000000476837,"connectStart":315.2000000476837,"domainLookupEnd":315.2000000476837,"domainLookupStart":315.2000000476837,"fetchStart":315.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":315.2000000476837,"responseEnd":603.2000000476837,"responseStart":603.2000000476837,"secureConnectionStart":315.2000000476837},{"duration":288,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":315.5,"connectEnd":315.5,"connectStart":315.5,"domainLookupEnd":315.5,"domainLookupStart":315.5,"fetchStart":315.5,"redirectEnd":0,"redirectStart":0,"requestStart":315.5,"responseEnd":603.5,"responseStart":603.5,"secureConnectionStart":315.5},{"duration":334.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":315.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":315.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":649.8999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":288.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":315.7999999523163,"connectEnd":315.7999999523163,"connectStart":315.7999999523163,"domainLookupEnd":315.7999999523163,"domainLookupStart":315.7999999523163,"fetchStart":315.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":315.7999999523163,"responseEnd":604,"responseStart":604,"secureConnectionStart":315.7999999523163},{"duration":334.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":315.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":315.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":650.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":288.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":316.09999990463257,"connectEnd":316.09999990463257,"connectStart":316.09999990463257,"domainLookupEnd":316.09999990463257,"domainLookupStart":316.09999990463257,"fetchStart":316.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":316.09999990463257,"responseEnd":604.5999999046326,"responseStart":604.5999999046326,"secureConnectionStart":316.09999990463257},{"duration":945,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":317,"connectEnd":317,"connectStart":317,"domainLookupEnd":317,"domainLookupStart":317,"fetchStart":317,"redirectEnd":0,"redirectStart":0,"requestStart":317,"responseEnd":1262,"responseStart":1262,"secureConnectionStart":317},{"duration":1322.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":325.39999985694885,"connectEnd":325.39999985694885,"connectStart":325.39999985694885,"domainLookupEnd":325.39999985694885,"domainLookupStart":325.39999985694885,"fetchStart":325.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":325.39999985694885,"responseEnd":1647.5,"responseStart":1647.5,"secureConnectionStart":325.39999985694885},{"duration":600.2000000476837,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":662.5999999046326,"connectEnd":662.5999999046326,"connectStart":662.5999999046326,"domainLookupEnd":662.5999999046326,"domainLookupStart":662.5999999046326,"fetchStart":662.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":662.5999999046326,"responseEnd":1262.7999999523163,"responseStart":1262.7999999523163,"secureConnectionStart":662.5999999046326},{"duration":708.9000000953674,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":962.8999998569489,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":962.8999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1671.7999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":129,"responseStart":308,"responseEnd":313,"domLoading":312,"domInteractive":1675,"domContentLoadedEventStart":1675,"domContentLoadedEventEnd":1737,"domComplete":2130,"loadEventStart":2130,"loadEventEnd":2131,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1649.8999998569489},{"name":"bigPipe.sidebar-id.end","time":1650.8999998569489},{"name":"bigPipe.activity-panel-pipe-id.start","time":1651.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1653.0999999046326},{"name":"activityTabFullyLoaded","time":1755.2000000476837}],"measures":[],"correlationId":"fd49bf69effbf4","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":121,"dbReadsTimeInMs":20,"dbConnsTimeInMs":30,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}