[MDEV-10657] incorrect result returned with binary protocol (prepared statements) - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL)
Fix Version/s: 5.5.59, 10.0.34, 10.2.12, 10.3.4, 10.1.31
Component/s: Prepared Statements
Labels:
None

Sprint:
10.2.11, 10.2.12

Description

runnig following test suite with and without --ps-protocol produce different results.

create table  DUPPP (code varchar(10) primary key);

INSERT INTO DUPPP(code) VALUES ('LINE1'), ('LINE2'), ('LINE3');

SELECT X.* FROM (SELECT CODE, RN FROM (SELECT A.CODE, @cnt := @cnt + 1 AS RN FROM  DUPPP A, (SELECT @cnt := 0) C) T) X;

drop table DUPP;

normal execution:

CODE	RN

LINE1	1

LINE2	2

LINE3	3

with --ps-protocol:

CODE	RN

LINE3	3

LINE3	3

LINE3	3

Attachments

Issue Links

relates to

CONJ-338 Inconsistent/wrong resultset when using variables and nested selects

Closed

Activity

Ascending order - Click to sort in descending order

Oleksandr Byelkin created issue - 2016-08-24 17:02

Oleksandr Byelkin made changes - 2016-08-24 17:02

Field	Original Value	New Value
Link		This issue relates to ~~CONJ-338~~ [ ~~CONJ-338~~ ]

Oleksandr Byelkin made changes - 2016-08-24 17:03

Link

This issue relates to ~~CONJ-338~~ [ ~~CONJ-338~~ ]

Oleksandr Byelkin made changes - 2016-08-24 17:13

Affects Version/s

5.5 [ 15800 ]

Oleksandr Byelkin made changes - 2016-08-24 17:23

Affects Version/s

10.0 [ 16000 ]

Diego Dupin made changes - 2016-08-24 17:24

Link

This issue relates to ~~CONJ-338~~ [ ~~CONJ-338~~ ]

Diego Dupin added a comment - 2016-08-24 17:39

to reproduced it easily on heidi with a query a little simpler:

prepare test from "SELECT * FROM (SELECT * FROM (SELECT seq FROM seq_1_to_3, (SELECT @cnt := 0) C) T) X";
execute test ;

will be :

3
3
3

Diego Dupin added a comment - 2016-08-24 17:39 to reproduced it easily on heidi with a query a little simpler: prepare test from "SELECT * FROM (SELECT * FROM (SELECT seq FROM seq_1_to_3, (SELECT @cnt := 0) C) T) X"; execute test ; will be : 3 3 3

Oleksandr Byelkin made changes - 2016-08-24 17:56

Assignee

Oleksandr Byelkin [ sanja ]

Oleksandr Byelkin made changes - 2016-08-24 17:57

Fix Version/s

5.5 [ 15800 ]

Oleksandr Byelkin made changes - 2016-08-24 17:58

Fix Version/s		10.0 [ 16000 ]
Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.2 [ 14601 ]

Oleksandr Byelkin made changes - 2017-11-08 07:29

Sprint

10.2.11 [ 203 ]

Oleksandr Byelkin made changes - 2017-11-13 15:37

Status

Open [ 1 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2017-11-13 15:44 - edited

OK, sequences appeared later than 5.5, but the bug present in 5.5 so the first test suite sill in use

Oleksandr Byelkin added a comment - 2017-11-13 15:44 - edited OK, sequences appeared later than 5.5, but the bug present in 5.5 so the first test suite sill in use

Oleksandr Byelkin made changes - 2017-11-13 19:04

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2017-11-14 16:23

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2017-11-14 21:13

there is no diferences in Item_func_set_user_var::update calls.

Oleksandr Byelkin added a comment - 2017-11-14 21:13 there is no diferences in Item_func_set_user_var::update calls.

Oleksandr Byelkin made changes - 2017-11-14 21:13

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2017-12-13 12:27

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2017-12-18 12:40

The difference is that in binary protocol fields of table T instaed of X somehow used.

Oleksandr Byelkin added a comment - 2017-12-18 12:40 The difference is that in binary protocol fields of table T instaed of X somehow used.

Oleksandr Byelkin added a comment - 2017-12-19 10:44

Prepare decide to merge X, then execution to materialize X.

Oleksandr Byelkin added a comment - 2017-12-19 10:44 Prepare decide to merge X, then execution to materialize X.

Oleksandr Byelkin added a comment - 2017-12-19 12:49 - edited

During statement prepare unit->prepared is set for X and so translation table created.

Oleksandr Byelkin added a comment - 2017-12-19 12:49 - edited During statement prepare unit->prepared is set for X and so translation table created.

Oleksandr Byelkin added a comment - 2017-12-20 13:02

Github tree: bb-5.5-~~MDEV-10657~~

revision-id: 24b4585ad0648f21519f47a04762e1b208918749 (mariadb-5.5.58-18-g24b4585ad06)
parent(s): 924db8b4ed3f268cbe91a1734611f4dc2311c7be
author: Oleksandr Byelkin
committer: Oleksandr Byelkin
timestamp: 2017-12-20 13:52:27 +0100
message:

~~MDEV-10657~~: incorrect result returned with binary protocol (prepared statements)

If translation table present when we materialize the derived table then
change it to point on the materialized table.

Added debug info to see really what happens with what derived.

Oleksandr Byelkin added a comment - 2017-12-20 13:02 Github tree: bb-5.5- MDEV-10657 revision-id: 24b4585ad0648f21519f47a04762e1b208918749 (mariadb-5.5.58-18-g24b4585ad06) parent(s): 924db8b4ed3f268cbe91a1734611f4dc2311c7be author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2017-12-20 13:52:27 +0100 message: MDEV-10657 : incorrect result returned with binary protocol (prepared statements) If translation table present when we materialize the derived table then change it to point on the materialized table. Added debug info to see really what happens with what derived.

Oleksandr Byelkin made changes - 2017-12-20 13:03

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2017-12-20 14:09

Sprint

10.2.11 [ 203 ]

10.2.11, 10.2.12 [ 203, 216 ]

Oleksandr Byelkin made changes - 2017-12-20 16:55

Assignee	Oleksandr Byelkin [ sanja ]	Igor Babaev [ igor ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Igor Babaev (Inactive) added a comment - 2017-12-24 22:36

Sanja, see your email with my review.

Igor Babaev (Inactive) added a comment - 2017-12-24 22:36 Sanja, see your email with my review.

Igor Babaev (Inactive) made changes - 2017-12-24 22:36

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Igor Babaev (Inactive) made changes - 2017-12-24 22:37

Assignee

Igor Babaev [ igor ]

Oleksandr Byelkin [ sanja ]

Oleksandr Byelkin made changes - 2017-12-27 15:07

Fix Version/s		5.5.59 [ 22612 ]
Fix Version/s		10.0.34 [ 22613 ]
Fix Version/s		10.2.12 [ 22810 ]
Fix Version/s		10.3.4 [ 22904 ]
Fix Version/s		10.1.31 [ 22907 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	5.5 [ 15800 ]
Fix Version/s	10.0 [ 16000 ]
Fix Version/s	10.1 [ 16100 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:43

Workflow

MariaDB v3 [ 76784 ]

MariaDB v4 [ 150815 ]

People

Assignee:: Oleksandr Byelkin

Reporter:: Oleksandr Byelkin

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2016-08-24 17:02

Updated:: 2017-12-27 15:07

Resolved:: 2017-12-27 15:07

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration