Details

    Description

      centos7 has gcc 4.8 which can no longer compile 11.8

      we need a new bintar builder in addition to centos7. centos7 will build 11.7-, and new one will build 11.8+

      Using debian 10 might be a good idea, because aarch bintars are built on debian 10.

      This must be done before the next release

      Attachments

        Issue Links

          Activity

            serg cvicentiu
            The new bintar was deployed in production, see: https://buildbot.mariadb.org/#/builders/857
            if you consider that other changes are needed , just let me know and I will handle it asap.

            rvarzaru Varzaru Razvan-Liviu added a comment - serg cvicentiu The new bintar was deployed in production, see: https://buildbot.mariadb.org/#/builders/857 if you consider that other changes are needed , just let me know and I will handle it asap.

            How do you package libgalera_smm.so ?

            Why is it listed twice?

            serg Sergei Golubchik added a comment - How do you package libgalera_smm.so ? Why is it listed twice?

            Is listed twice because of DEXTRA_FILES

            -DEXTRA_FILES="${WSREP_PROVIDER}=lib;${WSREP_PROVIDER}=lib/galera;" \
            

            This was taken from old-bb code which got commented at some point
            https://github.com/MariaDB/mariadb.org-tools/blob/b92c4e5db110dbfed22894ef0980f09a31c134f5/buildbot/maria-master.cfg#L5323

            #      extra="-DEXTRA_FILES=$p/lib/libgalera_smm.so=lib;$p/lib/galera/libgalera_smm.so=lib/galera"
            

            So I guess we started to manually add it into the packages since this commit? https://github.com/MariaDB/mariadb.org-tools/commit/90f5da9f8a09e75695859845800ae4e939852a9d

            rvarzaru Varzaru Razvan-Liviu added a comment - Is listed twice because of DEXTRA_FILES -DEXTRA_FILES= "${WSREP_PROVIDER}=lib;${WSREP_PROVIDER}=lib/galera;" \ This was taken from old-bb code which got commented at some point https://github.com/MariaDB/mariadb.org-tools/blob/b92c4e5db110dbfed22894ef0980f09a31c134f5/buildbot/maria-master.cfg#L5323 # extra= "-DEXTRA_FILES=$p/lib/libgalera_smm.so=lib;$p/lib/galera/libgalera_smm.so=lib/galera" So I guess we started to manually add it into the packages since this commit? https://github.com/MariaDB/mariadb.org-tools/commit/90f5da9f8a09e75695859845800ae4e939852a9d

            No, they were always added manually in the prepare-release script.

            I didn't like that, I wanted buildbot to produce ready-to-release packages, so I implemented -DEXTRA_FILES option.

            But it was never actually used, prep script was still replacing galera files in the bintars — because this was the only way to make sure bintars get the latest galera.

            I still think it's better to have buildbot to produce ready packages, and I don't like that bintars are tested with old galera but released with newer one, not something they were tested with. But to make it happen you need to create some process to make sure the galera in the bintar builders is always the latest one. Let's do it in a separate issue, it's not "reproducing old buildbot", because old buildbot never did that.

            serg Sergei Golubchik added a comment - No, they were always added manually in the prepare-release script. I didn't like that, I wanted buildbot to produce ready-to-release packages, so I implemented -DEXTRA_FILES option. But it was never actually used, prep script was still replacing galera files in the bintars — because this was the only way to make sure bintars get the latest galera. I still think it's better to have buildbot to produce ready packages, and I don't like that bintars are tested with old galera but released with newer one, not something they were tested with. But to make it happen you need to create some process to make sure the galera in the bintar builders is always the latest one. Let's do it in a separate issue, it's not "reproducing old buildbot", because old buildbot never did that.
            rvarzaru Varzaru Razvan-Liviu added a comment - - edited

            serg

            For the new-bintar, because we have an automated process to generate the builder,
            I thought of this before, and I handled it here: https://github.com/MariaDB/buildbot/blob/dev/ci_build_images/bintar.Dockerfile

            && dnf config-manager --add-repo https://ci.mariadb.org/galera/mariadb-4.x-latest-gal-${ARCH}-rhel${VERSION_ID}.repo \
            and then install galera-4
            

            This is the latest galera produced for amd64-rhel-8 by the dedicated galera builder.
            We don't have an alma-linux-8 galera builder as of now, I know packages between rhel-8 / alma-linux 8 should be compatible.

            As for centos-7-bintar is not so easy to maintain because it's EOL so maybe there you'll be ok with the "re-packaging" method

            I opened https://jira.mariadb.org/browse/MDBF-935 to track current problems. cc: cvicentiu
            I'm having a hard time to make libncurses.a behave properly on centos-7 so that all the required functions are found in the static library, it's not the case for the new bintar (there I can fix it) .

            I will keep you up to date on MDBF-935.

            rvarzaru Varzaru Razvan-Liviu added a comment - - edited serg For the new-bintar, because we have an automated process to generate the builder, I thought of this before, and I handled it here: https://github.com/MariaDB/buildbot/blob/dev/ci_build_images/bintar.Dockerfile && dnf config-manager --add-repo https: //ci.mariadb.org/galera/mariadb-4.x-latest-gal-${ARCH}-rhel${VERSION_ID}.repo \ and then install galera- 4 This is the latest galera produced for amd64-rhel-8 by the dedicated galera builder. We don't have an alma-linux-8 galera builder as of now, I know packages between rhel-8 / alma-linux 8 should be compatible. As for centos-7-bintar is not so easy to maintain because it's EOL so maybe there you'll be ok with the "re-packaging" method I opened https://jira.mariadb.org/browse/MDBF-935 to track current problems. cc: cvicentiu I'm having a hard time to make libncurses.a behave properly on centos-7 so that all the required functions are found in the static library, it's not the case for the new bintar (there I can fix it) . I will keep you up to date on MDBF-935 .

            People

              rvarzaru Varzaru Razvan-Liviu
              serg Sergei Golubchik
              Vicențiu Ciorbaru Vicențiu Ciorbaru
              Vicențiu Ciorbaru Vicențiu Ciorbaru
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 4d 2.5h
                  4d 2.5h