Uploaded image for project: 'MariaDB Connector/node.js'
  1. MariaDB Connector/node.js
  2. CONJS-266

Option `infileStreamFactory` addition for compatibility

Details

    • Task
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.1
    • compatibility
    • None

    Description

      Option `infileStreamFactory` permit having a callback for LOAD LOCAL commands.
      In other mysql connectors, this callback permits 2 behaviors :

      • validate file name
      • permit to return a stream, so this can permit not using local file

      MariaDB connector already validate file name, but this will be implemented for compatibility

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          diego dupin Diego Dupin created issue -
          diego dupin Diego Dupin made changes -
          Field Original Value New Value
          issue.field.resolutiondate 2023-09-07 14:33:32.0 2023-09-07 14:33:32.144
          diego dupin Diego Dupin made changes -
          Component/s compatibility [ 14522 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          diego dupin Diego Dupin added a comment - - edited

          example of use: 

            function isWithin(outer, inner) {
          		 
              const rel = path.relative(outer, inner);
          		 
              return !rel.startsWith('../') && rel !== '..';
          		 
            }
          		 
           const conn = await mariadb.createConnection({
          		 
                host: 'localhost',
          		 
                user: 'root',
          		 
                permitLocalInfile: true,
          		 
                infileStreamFactory: (filePath) => {
          		 
                  // this is an example, that required local file to only comes from temporay folder
          		 
                  if (!isWithin(os.tmpdir(), filePath)) {
          		 
                    throw new Error(`Application only expect to send file from ${os.tmpdir()}, but file ${filePath} was asked`);
          		 
                  }
          		 
                  return fs.createReadStream(smallFileName);
          		 
                }
          		 
              });

          diego dupin Diego Dupin added a comment - - edited example of use: function isWithin(outer, inner) { const rel = path.relative(outer, inner); return !rel.startsWith( '../' ) && rel !== '..' ; } const conn = await mariadb.createConnection({ host: 'localhost' , user: 'root' , permitLocalInfile: true , infileStreamFactory: (filePath) => { // this is an example, that required local file to only comes from temporay folder if (!isWithin(os.tmpdir(), filePath)) { throw new Error(`Application only expect to send file from ${os.tmpdir()}, but file ${filePath} was asked`); } return fs.createReadStream(smallFileName); } });

          People

            diego dupin Diego Dupin
            diego dupin Diego Dupin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.