Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-729

MYSQL_OPT_SSL_MODE

Details

    • New Feature
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • None
    • None
    • TLS/SSL
    • None

    Description

      MySQL has removed MYSQL_OPT_SSL_ENFORCE in favour of MYSQL_OPT_SSL_MODE which isn't supported on MariaDB. This means that <database:tls> doesn't work on MariaDB.

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-28906 MySQL 8.0 desired compatibility

          • Major - Major loss of function.
          • Open
          links to

          Web Link https://github.com/inspircd/docs/issues/239#issuecomment-2301962809

          Activity

            Ascending order - Click to sort in descending order
            rsilen Robert Silén created issue -
            rsilen Robert Silén made changes -
            Field Original Value New Value
            rsilen Robert Silén made changes -
            danblack Daniel Black made changes -
            Component/s TLS/SSL [ 16815 ]
            Component/s compat80 [ 19003 ]
            Key MDEV-34948 CONC-729
            Issue Type Task [ 3 ] New Feature [ 2 ]
            Project MariaDB Server [ 10000 ] MariaDB Connector/C [ 10300 ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            danblack Daniel Black made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] Georg Richter [ georg ]
            serg Sergei Golubchik added a comment -

            The module already has

            342
            		 
            #if defined LIBMYSQL_VERSION_ID && LIBMYSQL_VERSION_ID > 80000
            		 
            343
            		 
                            unsigned int ssl = config->getBool("ssl") ? SSL_MODE_REQUIRED : SSL_MODE_PREFERRED;
            		 
            344
            		 
                            mysql_options(connection, MYSQL_OPT_SSL_MODE, &ssl);
            		 
            345
            		 
            #endif

            A fix for MariaDB would've been

                             mysql_options(connection, MYSQL_OPT_SSL_MODE, &ssl);
            		 
            +#elif defined MARIADB_PACKAGE_ID
            		 
            +                unsigned my_bool ssl = config->getBool("ssl"), on= 1;
            		 
            +                mysql_optionsv(connection, MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl);
            		 
            +                mysql_optionsv(connection, MYSQL_OPT_SSL_ENFORCE, &on);
            		 
             #endif

            I can do a pull request, if it'd be easier

            serg Sergei Golubchik added a comment - The module already has 342 #if defined LIBMYSQL_VERSION_ID && LIBMYSQL_VERSION_ID > 80000 343 unsigned int ssl = config->getBool( "ssl" ) ? SSL_MODE_REQUIRED : SSL_MODE_PREFERRED; 344 mysql_options(connection, MYSQL_OPT_SSL_MODE, &ssl); 345 #endif A fix for MariaDB would've been mysql_options(connection, MYSQL_OPT_SSL_MODE, &ssl); +#elif defined MARIADB_PACKAGE_ID + unsigned my_bool ssl = config->getBool("ssl"), on= 1; + mysql_optionsv(connection, MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl); + mysql_optionsv(connection, MYSQL_OPT_SSL_ENFORCE, &on); #endif I can do a pull request, if it'd be easier

            People

              georg Georg Richter
              rsilen Robert Silén
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.