"MariaDB uses MYSQL_VERSION_ID for its own version which breaks checking for features based on MySQL version. We currently get around this by using LIBMYSQL_VERSION_ID for checking for recent features instead which doesn't work on MariaDB as it was forked before that was added. We could get around this by adding specific code for checking for MariaDB but also there's several other MySQL forks which we would need to do the same for and that can end up being really messy. Ideally MySQL forks should be using that version for the version of MySQL they are compatible with and adding their own macro for their version."
- is part of
-
MDEV-28906
MySQL 8.0 desired compatibility
-
-
Open
- links to
-
{"report":{"fcp":1239.8999999761581,"ttfb":338,"pageVisibility":"visible","entityId":130781,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"e4aecf30-989c-4099-9561-77ce544d9621","navigationType":0,"readyForUser":1313.8999999761581,"redirectCount":0,"resourceLoadedEnd":1682.8999999761581,"resourceLoadedStart":343.59999990463257,"resourceTiming":[{"duration":388.10000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":343.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":343.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":731.6999999284744,"responseStart":0,"secureConnectionStart":0},{"duration":388.1999999284744,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":343.89999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":343.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":732.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":442.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":344,"connectEnd":344,"connectStart":344,"domainLookupEnd":344,"domainLookupStart":344,"fetchStart":344,"redirectEnd":0,"redirectStart":0,"requestStart":344,"responseEnd":786.7999999523163,"responseStart":786.7999999523163,"secureConnectionStart":344},{"duration":514.8999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":344.1999999284744,"connectEnd":344.1999999284744,"connectStart":344.1999999284744,"domainLookupEnd":344.1999999284744,"domainLookupStart":344.1999999284744,"fetchStart":344.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":344.1999999284744,"responseEnd":859.0999999046326,"responseStart":859.0999999046326,"secureConnectionStart":344.1999999284744},{"duration":517.8999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":344.39999997615814,"connectEnd":344.39999997615814,"connectStart":344.39999997615814,"domainLookupEnd":344.39999997615814,"domainLookupStart":344.39999997615814,"fetchStart":344.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":344.39999997615814,"responseEnd":862.2999999523163,"responseStart":862.2999999523163,"secureConnectionStart":344.39999997615814},{"duration":518.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":344.59999990463257,"connectEnd":344.59999990463257,"connectStart":344.59999990463257,"domainLookupEnd":344.59999990463257,"domainLookupStart":344.59999990463257,"fetchStart":344.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":344.59999990463257,"responseEnd":863.0999999046326,"responseStart":863.0999999046326,"secureConnectionStart":344.59999990463257},{"duration":518.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":344.7999999523163,"connectEnd":344.7999999523163,"connectStart":344.7999999523163,"domainLookupEnd":344.7999999523163,"domainLookupStart":344.7999999523163,"fetchStart":344.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":344.7999999523163,"responseEnd":863.3999999761581,"responseStart":863.3999999761581,"secureConnectionStart":344.7999999523163},{"duration":584.2999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":345,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":345,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":929.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":519,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":345.09999990463257,"connectEnd":345.09999990463257,"connectStart":345.09999990463257,"domainLookupEnd":345.09999990463257,"domainLookupStart":345.09999990463257,"fetchStart":345.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":345.09999990463257,"responseEnd":864.0999999046326,"responseStart":864.0999999046326,"secureConnectionStart":345.09999990463257},{"duration":584.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":345.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":345.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":929.5,"responseStart":0,"secureConnectionStart":0},{"duration":519.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":345.39999997615814,"connectEnd":345.39999997615814,"connectStart":345.39999997615814,"domainLookupEnd":345.39999997615814,"domainLookupStart":345.39999997615814,"fetchStart":345.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":345.39999997615814,"responseEnd":864.8999999761581,"responseStart":864.8999999761581,"secureConnectionStart":345.39999997615814},{"duration":850,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":346.39999997615814,"connectEnd":346.39999997615814,"connectStart":346.39999997615814,"domainLookupEnd":346.39999997615814,"domainLookupStart":346.39999997615814,"fetchStart":346.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":346.39999997615814,"responseEnd":1196.3999999761581,"responseStart":1196.3999999761581,"secureConnectionStart":346.39999997615814},{"duration":1278,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":346.5,"connectEnd":346.5,"connectStart":346.5,"domainLookupEnd":346.5,"domainLookupStart":346.5,"fetchStart":346.5,"redirectEnd":0,"redirectStart":0,"requestStart":346.5,"responseEnd":1624.5,"responseStart":1624.5,"secureConnectionStart":346.5},{"duration":255.79999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":941.8999999761581,"connectEnd":941.8999999761581,"connectStart":941.8999999761581,"domainLookupEnd":941.8999999761581,"domainLookupStart":941.8999999761581,"fetchStart":941.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":941.8999999761581,"responseEnd":1197.6999999284744,"responseStart":1197.6999999284744,"secureConnectionStart":941.8999999761581},{"duration":417.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1233.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1233.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1651.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":425.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1257.1999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1257.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1682.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":425.10000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2bu7/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1257.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1257.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1682.8999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":415.3000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1258.5999999046326,"connectEnd":1258.5999999046326,"connectStart":1258.5999999046326,"domainLookupEnd":1258.5999999046326,"domainLookupStart":1258.5999999046326,"fetchStart":1258.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1258.5999999046326,"responseEnd":1673.8999999761581,"responseStart":1673.8999999761581,"secureConnectionStart":1258.5999999046326},{"duration":419.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1259.1999999284744,"connectEnd":1259.1999999284744,"connectStart":1259.1999999284744,"domainLookupEnd":1259.1999999284744,"domainLookupStart":1259.1999999284744,"fetchStart":1259.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":1259.1999999284744,"responseEnd":1678.7999999523163,"responseStart":1678.7999999523163,"secureConnectionStart":1259.1999999284744},{"duration":420.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/86ee9bbc76cd1bcd8556fcdcf46241c9-CDN/lu2bu7/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1259.5999999046326,"connectEnd":1259.5999999046326,"connectStart":1259.5999999046326,"domainLookupEnd":1259.5999999046326,"domainLookupStart":1259.5999999046326,"fetchStart":1259.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1259.5999999046326,"responseEnd":1680.1999999284744,"responseStart":1680.1999999284744,"secureConnectionStart":1259.5999999046326}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":172,"responseStart":338,"responseEnd":341,"domLoading":341,"domInteractive":1683,"domContentLoadedEventStart":1683,"domContentLoadedEventEnd":1724,"domComplete":1875,"loadEventStart":1875,"loadEventEnd":1876,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1628.2999999523163},{"name":"bigPipe.sidebar-id.end","time":1629.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1629.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1631},{"name":"activityTabFullyLoaded","time":1741}],"measures":[],"correlationId":"15281608cf9223","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":104,"dbReadsTimeInMs":16,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
rsilen: Do we really need LIBMYSQL_VERSION_ID beside MARIADB_PACKAGE_ID ?
For compile time checking MARIADB_PACKAGE_ID could be used:
#ifdef MARIADB_PACKAGE_ID
#if MARIADB_PACKAGE_ID > 30400
#define HAVE_PARSEC_PLUGIN
#endif
For runtime checking mysql_get_client_version should be used:
{
}