Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-628

Version string cannot be split fully

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 3.1
    • 3.1.20
    • Other
    • None

    Description

        File "/root/.pyenv/versions/3.10.7/lib/python3.10/site-packages/mariadb/__init__.py", line 136, in <module>
      		 
        File "/root/.pyenv/versions/3.10.7/lib/python3.10/site-packages/mariadb/__init__.py", line 136, in <genexpr>
      		 
      ValueError: invalid literal for int() with base 10: '17-12'

      when installing MariaDB Server 10.5.17 or 10.5.18 on a CentOS 7 host, the mariadb connector is throwing this error to us during our connect.

      >10.6 is not throwing this issue.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. CONPY-244 Check the version of libmariadb.so during module initialization

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            georg Georg Richter added a comment - - edited

            During initialization mariadb module loads the client version via mysql_get_client_info into mariadbapi_version.

            mysql_get_client_info uses MARIADB_PACKAGE_VERSION macro, which is defined in mariadb_version.h. It has the format major.minor.patch.

            Obviously someone changed this to another format when building ES packages, instead of 3.3.3 it was changed to 10.5.17-12,which explains this issue.

            This change in ES also has other impacts, e.g. it is impossible to determine if a feature is supported by checking the client version (10 is always > 3)

            georg Georg Richter added a comment - - edited During initialization mariadb module loads the client version via mysql_get_client_info into mariadbapi_version. mysql_get_client_info uses MARIADB_PACKAGE_VERSION macro, which is defined in mariadb_version.h. It has the format major.minor.patch. Obviously someone changed this to another format when building ES packages, instead of 3.3.3 it was changed to 10.5.17-12,which explains this issue. This change in ES also has other impacts, e.g. it is impossible to determine if a feature is supported by checking the client version (10 is always > 3)
            georg Georg Richter added a comment -

            cole.busby Could you please attach output from mariadb_config and the include file mariadb_version.h from ES installation?

            georg Georg Richter added a comment - cole.busby Could you please attach output from mariadb_config and the include file mariadb_version.h from ES installation?
            georg Georg Richter added a comment - - edited

            Changed status to "needs feedback"

            georg Georg Richter added a comment - - edited Changed status to "needs feedback"
            georg Georg Richter added a comment -

            MariaDB Connector/Python v1.1.3 requires MariaDB Connector/C >= 3.2.4, actual version (v.1.1.5) requires 3.3.1 (3.2 is discontinued).

            in mariadb_posix.py (v1.1.3)
            required_version = "3.2.4"

            MariaDB ES 10.5.x ships Connector/C 3.1 - which is < 3.2.4. If the installation passed, it indicates that the C/C version was modified (and bumped) and all further capability checks (in mostly every product) will return wrong results.

            georg Georg Richter added a comment - MariaDB Connector/Python v1.1.3 requires MariaDB Connector/C >= 3.2.4, actual version (v.1.1.5) requires 3.3.1 (3.2 is discontinued). in mariadb_posix.py (v1.1.3) required_version = "3.2.4" MariaDB ES 10.5.x ships Connector/C 3.1 - which is < 3.2.4. If the installation passed, it indicates that the C/C version was modified (and bumped) and all further capability checks (in mostly every product) will return wrong results.
            georg Georg Richter added a comment -

            The problem is that MariaDB Connector/Python was built with the required minimum version of Connector/C, but an older connector/c client library is in default path.

            georg Georg Richter added a comment - The problem is that MariaDB Connector/Python was built with the required minimum version of Connector/C, but an older connector/c client library is in default path.
            georg Georg Richter added a comment -

            Not a bug, since the correct version of Connector/C is not in default place, so the unsupported Connector/C shared library from ES will be loaded instead.

            Fix for CONPY-244 will now throw an exception during module initialization if an incompatible library was loaded.

            georg Georg Richter added a comment - Not a bug, since the correct version of Connector/C is not in default place, so the unsupported Connector/C shared library from ES will be loaded instead. Fix for CONPY-244 will now throw an exception during module initialization if an incompatible library was loaded.
            serg Sergei Golubchik added a comment -

            This is Connector/C bug, it was returning a wrong version to the Connector/Python.

            Fixed in https://github.com/mariadb-corporation/mariadb-connector-c/commit/d204e83104222844251b221e9be7eb3dd9f8d63d

            serg Sergei Golubchik added a comment - This is Connector/C bug, it was returning a wrong version to the Connector/Python. Fixed in https://github.com/mariadb-corporation/mariadb-connector-c/commit/d204e83104222844251b221e9be7eb3dd9f8d63d

            People

              georg Georg Richter
              cole.busby Cole Busby (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.