Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-619

NULL pointer dereference in unpack_fields (libmariadb)

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • None
    • 3.1.21
    • Internal
    • None

    Description

      libmariadb/mariadb_lib.c

          ...
      		 
          for (i=0; i < field_count; i++)
      		 
          {
      		 
            uint length= (uint)(row->data[i+1] - row->data[i] - 1);
      		 
            if (!row->data[i] && row->data[i][length])
      		 
              goto error;
      		 
          ...

      Even if row->data[i] is NULL we still continue condition evaluation and dereference NULL pointer in row->data[i][length]. Possibly || should be used instead of &&.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          yury.chaikou Yury Chaikou created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Key MDEV-30040 CONC-619
          Project MariaDB Server [ 10000 ] MariaDB Connector/C [ 10300 ]
          serg Sergei Golubchik made changes -
          Assignee Georg Richter [ georg ]
          serg Sergei Golubchik made changes -
          Fix Version/s 3.1 [ 23223 ]
          serg Sergei Golubchik made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          georg Georg Richter added a comment -

          This was already fixed in rev. a3bba4639f55148c59a28a506df8a2b88e5e83ab (C/C vers. 3.1.21)

          georg Georg Richter added a comment - This was already fixed in rev. a3bba4639f55148c59a28a506df8a2b88e5e83ab (C/C vers. 3.1.21)
          georg Georg Richter made changes -
          Component/s Internal [ 16816 ]
          Fix Version/s 3.1.21 [ 28612 ]
          Fix Version/s 3.1 [ 23223 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]

          People

            georg Georg Richter
            yury.chaikou Yury Chaikou
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.