Details
-
Task
-
Status: Open (View Workflow)
-
Minor
-
Resolution: Unresolved
-
None
-
None
Description
When using C/C within python, every api call needs to be encapsulated by BEGIN/END Threads, e.g.
Py_BEGIN_ALLOW_THREADS()
|
rc= mysql_stmt_execute(self->stmt);
|
Py_END_ALLOW_THREADS()
|
This causes a lot of overhead, in case of callback function for filling values was specified: Whenever calling python code inside mysql_stmt_execute() we need to call Py_END_ALLOW_THREADS and Py_BEGIN_ALLOW_THREADS() again.
Instead of it would be much easier to have a call which fills the buffer and another call which executes the stmt:
buffer= self->connection->mysql->methods->generate_execute_request(self->stmt, &buflen)
|
PY_BEGIN_ALLOW_THREADS()
|
rc= self-connection->mysql->methods->send_command(COM_STMT_EXECUTE, buffer, buflen, ...)
|
PY_BEGIN_END_THREADS()
|
PY_END_ALLOW_THREADS()
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | Add generate_request functios (stmt_execute and bulk_execute) to internal API | Add generate_request functions (stmt_execute and bulk_execute) to internal API |
| Description |
When using C/C within python, every api call needs to be encapsulated by BEGIN/END Threads, e.g.
{code:C} Py_BEGIN_ALLOW_THREADS() rc= mysql_stmt_execute(self->stmt); Py_END_ALLOW_THREADS() {code} This causes a lot of overhead, in case of callback function for filling values was specified: Whenever calling python code inside mysql_stmt_execute() we need to call Py_END_ALLOW_THREADS and Py_BEGIN_ALLOW_THREADS() again. Instead of it would be much easier to have a call which fills the buffer and another call which executes the stmt: buffer= self->connection->mysql->methods->generate_execute_request(self->stmt, &buflen) {code:C} PY_BEGIN_ALLOW_THREADS() rc= self-connection->mysql->methods->send_command(COM_STMT_EXECUTE, buffer, buflen, ...) PY_BEGIN_END_THREADS() {code} PY_END_ALLOW_THREADS() |
When using C/C within python, every api call needs to be encapsulated by BEGIN/END Threads, e.g.
{code:C} Py_BEGIN_ALLOW_THREADS() rc= mysql_stmt_execute(self->stmt); Py_END_ALLOW_THREADS() {code} This causes a lot of overhead, in case of callback function for filling values was specified: Whenever calling python code inside mysql_stmt_execute() we need to call Py_END_ALLOW_THREADS and Py_BEGIN_ALLOW_THREADS() again. Instead of it would be much easier to have a call which fills the buffer and another call which executes the stmt: {code:C} buffer= self->connection->mysql->methods->generate_execute_request(self->stmt, &buflen) PY_BEGIN_ALLOW_THREADS() rc= self-connection->mysql->methods->send_command(COM_STMT_EXECUTE, buffer, buflen, ...) PY_BEGIN_END_THREADS() {code} PY_END_ALLOW_THREADS() |
| Fix Version/s | 3.2 [ 25627 ] | |
| Fix Version/s | 3.2.0 [ 25122 ] |
| Workflow | MariaDB connectors [ 121588 ] | MariaDB v4 [ 160880 ] |
| Fix Version/s | 3.4 [ 28329 ] | |
| Fix Version/s | 3.2 [ 25627 ] |
| Priority | Major [ 3 ] | Minor [ 4 ] |
| Component/s | Documentation [ 16811 ] | |
| Component/s | Prepared Statements [ 16820 ] |