Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-347

Add new api function mariadb_stmt_fetch_fields

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • Documentation
    • None

    Description

      To get metadata information for the binary protocol (prepared statements), a resultset handle must be allocated via mysql_stmt_result_metadata() which contains a pointer to stmt-> fields. Afterwards this handle must be released via mysql_free_result().

      Instead of allocating and freeing memory it would be much simpler to have an additional API function mariadb_stmt_fetch_fields() which just returns stmt->fields:

      MYSQL_FIELD STDCALL *mariadb_stmt_fetch_fields(MYSQL_STMT *stmt)
      		 
      {
      		 
        if (stmt)
      		 
          return stmt->fields;
      		 
        return NULL;
      		 
      }

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          georg Georg Richter added a comment -

          Hi, can you please review - implementation can be found in cc_python branch.

          georg Georg Richter added a comment - Hi, can you please review - implementation can be found in cc_python branch.
          Lawrin Lawrin Novitsky added a comment -

          Are you sure that you should do the same in mysql_stmt_result_metadata? i.e. only copy pointer to fields from stmt. What if application somehow stores and uses that MYSQL_RES structure after stmt handler somehow changed? well, probably effectively means closed. I can't think of any good reason for that, but still.
          Currently, C/ODBC can use only new mariadb_stmt_fetch_fields. Thus it won't lose much, if mysql_stmt_result_metadata stays as is.

          Lawrin Lawrin Novitsky added a comment - Are you sure that you should do the same in mysql_stmt_result_metadata? i.e. only copy pointer to fields from stmt. What if application somehow stores and uses that MYSQL_RES structure after stmt handler somehow changed? well, probably effectively means closed. I can't think of any good reason for that, but still. Currently, C/ODBC can use only new mariadb_stmt_fetch_fields. Thus it won't lose much, if mysql_stmt_result_metadata stays as is.

          People

            georg Georg Richter
            georg Georg Richter
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.