[R2DBC-25] Statement::add correction after specification precision Created: 2021-06-22  Updated: 2021-06-23  Resolved: 2021-06-23

Status: Closed
Project: MariaDB Connector/R2DBC
Component/s: batch
Affects Version/s: None
Fix Version/s: 1.0.2

Type: Bug Priority: Major
Reporter: Diego Dupin Assignee: Diego Dupin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d
Original Estimate: 1d


 Description   

see https://github.com/r2dbc/r2dbc-spi/issues/229
Statement batching differ from Batch implementation, see https://github.com/r2dbc/r2dbc-spi/blob/main/r2dbc-spec/src/main/asciidoc/statements.adoc#batching

Current implementation required to have Statement::add call after each batching.
Correction needs to take in account current bind parameters.

 Comments   
Comment by Diego Dupin [ 2021-06-22 ]

correction will do has others drivers do for now: using current bindings, and permitting add() doing nothing if no bindings.
That means not throwing an error if not having any bindings on add().
This permits :

  • compatibility with current implementation.
  • compatibility with other drivers.

In a futur major version, Statement.add without any binding when expecting parameters will throw an errors.

Generated at Thu Feb 08 03:32:07 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.