[ODBC-294] Fail to build due to missing ma_global.h file Created: 2020-11-02  Updated: 2020-12-10  Resolved: 2020-12-10

Status: Closed
Project: MariaDB Connector/ODBC
Component/s: General
Affects Version/s: 3.1.10
Fix Version/s: 3.1.11

Type: Bug Priority: Major
Reporter: Lukas Javorsky Assignee: Lawrin Novitsky
Resolution: Fixed Votes: 0
Labels: Connectors, ODBC
Environment:

Fedora, RHEL



 Description   

Hi, Lukas from Red Hat here.

I'm co-maintainer for MariaDB and MySQL packages for Fedora and RHEL, and I've just run into one problem, I would like to discuss with you.

When building mariadb-connector-odbc-3.1.10, make ends with an error.

This error is caused by this line: https://github.com/mariadb-corporation/mariadb-connector-odbc/blob/master/ma_conv_charset.c#L32

Error: mariadb-connector-odbc-3.1.10-ga-src/ma_conv_charset.c:32:10: fatal error: ma_global.h: No such file or directory

You have linked mariadb-connector-c into the GitHub repo that's why it's not failing for you, however, we build it with 'mariadb-connector-c' dependency as well, but the 'ma_global.h' file is not available from connector-c package.

I would like to discuss further steps, how we can handle this together, because it's affecting the new release for us, and we have to fix this.

Maybe you can ship this library with the mariadb-connector-odbc package as well, or edit the include to something else.

Please let me know what's your opinion on this one.
Thank you for your help
Lukas



 Comments   
Comment by Lawrin Novitsky [ 2020-11-02 ]

atm it looks like a new C/ODBC release would be the best option. Especially since new C/C release should be out soon.

And we should add somewhere the test of such build to avoid such mistakes in future.

Comment by Lawrin Novitsky [ 2020-11-02 ]

I've pushed the fix, but leaving the issue open - still need to add test

Generated at Thu Feb 08 03:27:38 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.