[ODBC-258] RFE: make documentation and license dirs configurable Created: 2019-06-25 Updated: 2021-03-22 Resolved: 2019-06-27 |
|
| Status: | Closed |
| Project: | MariaDB Connector/ODBC |
| Component/s: | General |
| Affects Version/s: | 3.1.1 |
| Fix Version/s: | 3.1.2 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Michal Schorm | Assignee: | Lawrin Novitsky |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Fedora |
||
| Description |
|
First of all:
IMHO that should be fixed to use the dashes. If the non GNU/Linux distributions use underscores, there probbably should be if clause. Now to the core issue: In Fedora (RHEL, CentOS, ...) the documentation lies in "/usr/share/doc/<pkgname>" and license files are located in "/usr/share/licenses/<pkgname>". I'd like to have those two paths configurable for that reason.
This way it will default to what is hardcoded now, while granting the freedom to change any of those paths if necessary. I'm not sure however, how to add those macros to show up with description when "cmake -LAH" is called Also I'm not sure if you have something like "COMPONENT License", which could be used there. |
| Comments |
| Comment by Lawrin Novitsky [ 2019-06-26 ] |
|
Thank you. I guess the proposed patch makes sense. But I guess I must ask you if you submitting it under BSD license, or if you wish to sign code contribution agreement https://mariadb.com/kb/en/mariadb/mca/ |
| Comment by Michal Schorm [ 2019-06-26 ] |
|
I'm a MCA signatory. |
| Comment by Lawrin Novitsky [ 2019-06-27 ] |
|
The proposed fix has been pushed. I only made new parameter cache variables(to let them appear in the cmake -LA) |
| Comment by Michal Schorm [ 2019-06-27 ] |
|
Awesome, thanks! I tested the patch on the released 3.1.1 tarball and it builds just fine. |