[MXS-454] log_augmentation does not accept boolean parameters Created: 2015-11-06 Updated: 2015-11-06 Resolved: 2015-11-06 |
|
| Status: | Closed |
| Project: | MariaDB MaxScale |
| Component/s: | Core |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | markus makela | Assignee: | Johan Wikman |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Description |
|
log_augmentation only accepts 1 and 0 for values and is not in line with rest of the Boolean parameters in MaxScale. The config_truth_value function should be used instead. |
| Comments |
| Comment by Johan Wikman [ 2015-11-06 ] |
|
Actually it was not intended to be a boolean, but a bitmask. The current 1 turns on the bit that causes messages to be augmented with the function name. The original idea was that 2 would turn on the bit that causes messages to be augmented with the source file, and 4 would turn on the bit that causes messages to be augmented with the line. Thus, log_augmentation=1 would give you "...(some_function)...", log_augmentation=2 would give you "...(readwritesplitter.c)...", log_augmentation=5 would give you "...(some_function:345) and log_augmentation=6 would give you "...(readwritesplitter.c:345)...". But now that seems a bit too engineer-like so perhaps something like log_augmentation=(function|function_line|file|file_line) would be better. |