[MXS-450] Syslog default prefix is MaxScale not maxscale Created: 2015-11-05  Updated: 2015-11-24  Resolved: 2015-11-24

Status: Closed
Project: MariaDB MaxScale
Component/s: Core
Affects Version/s: 1.3.0
Fix Version/s: 1.3.0

Type: Bug Priority: Trivial
Reporter: Simon J Mudd Assignee: markus makela
Resolution: Fixed Votes: 0
Labels: None


 Description   

MaxScale logs in syslog using the default identifier MaxScale.

This is not the same as the program name which is maxscale (lower case).

I think that for clarity it would make sense by default to use the same as the binary and thus log using the name 'maxscale' rather than 'MaxScale' which is the current behaviour.

So current logging (during a shutdown shows):

Nov  5 07:37:23 h.example.com MaxScale[2049]: MaxScale is shutting down.
 
Nov  5 07:37:23 h.example.com MaxScale[2049]: MaxScale shutdown completed.
 
...
 
Nov  5 07:37:25 h.example.com MaxScale[37420]: Configuration file: /etc/maxscale.cnf
 
Nov  5 07:37:25 h.example.com MaxScale[37420]: Log directory: /var/log/maxscale/
 
Nov  5 07:37:25 h.example.com MaxScale[37420]: Data directory: /var/lib/maxscale/data
 
Nov  5 07:37:25 h.example.com MaxScale[37420]: Module directory: /usr/lib64/maxscale

and 

Nov  5 07:37:23 h.example.com maxscale[2049]: MaxScale is shutting down.
 
Nov  5 07:37:23 h.example.com maxscale[2049]: MaxScale shutdown completed.
 
...
 
Nov  5 07:37:25 h.example.com maxscale[37420]: Configuration file: /etc/maxscale.cnf
 
Nov  5 07:37:25 h.example.com maxscale[37420]: Log directory: /var/log/maxscale/
 
Nov  5 07:37:25 h.example.com maxscale[37420]: Data directory: /var/lib/maxscale/data
 
Nov  5 07:37:25 h.example.com maxscale[37420]: Module directory: /usr/lib64/maxscale

would look better to me.

Yes I know this option is configurable but I don't think that the default value is completely clean.

 Comments   
Comment by markus makela [ 2015-11-07 ]

This would make sense since externally MaxScale is always referred as maxscale. The init scripts use maxscale as do the systemd service files so this would keep it in line with them.

Comment by Simon J Mudd [ 2015-11-24 ]

This is marked as fixed. Thanks.

It would be good for fixes like this if you could provide the git commit of the change that fixed this so it's easier to trace, especially as I do not see MXS-450 referenced in any of MaxScale's git commit logs. (Perhaps I've missed something?)

Generated at Thu Feb 08 03:59:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.