[MXS-3957] Remove the `Don't Limit` option for max_rows value of the Query Editor Created: 2022-01-20  Updated: 2022-03-01  Resolved: 2022-02-18

Status: Closed
Project: MariaDB MaxScale
Component/s: maxgui
Affects Version/s: 6.2.1
Fix Version/s: 6.2.3

Type: Bug Priority: Major
Reporter: Naresh Chandra Assignee: Duong Thien Ly
Resolution: Fixed Votes: 0
Labels: None

Attachments: PNG File image-2022-01-25-13-04-45-560.png     PNG File screenshot-1.png    
Sprint: MXS-SPRINT-151

 Description   

If we change the Max_Rows from number to Don't Limit or any other number option then after disconnecting from the Query Editor or logout from the Maxscale and then after login and connect to the query editor also its still in Don't Limit mode or any other number only, as expected after disconnect from the Query editor/ logout from the maxscale, it should automatically change the max_rows to default 10000 limit. When user session is closed/logout then automatically it should set the max_rows value to 10000 in the GUI.



 Comments   
Comment by Duong Thien Ly [ 2022-01-24 ]

This is expected behavior for the Query Editor. The value for max_rows is used as a session system variable in the server. In the GUI, the query editor just persists the value in the browser. You can test it via the CLI by querying this

SHOW variables like 'sql_select_limit'

It would not use the value from the GUI.

Comment by Naresh Chandra [ 2022-01-24 ]

Hi Duong,

But, when the max_rows option changed to something else other than default(10000), after logout and login, can make it always default would be good.
We are expecting this after logout not in the current session.

Comment by Duong Thien Ly [ 2022-01-24 ]

Hi Naresh,
This is actually hard to decide. Others may want to keep the value after logging out. Besides, it doesn't have much effect on the user experience. Anyways, this is debatable. So I'll mark this as "Needs feedback", if other users want the same behavior as you suggested, I'll make the changes.

Comment by Naresh Chandra [ 2022-01-24 ]

Hi Duong,

As the max_rows=Don't Limit is casuing memory issue for big tables, any how after login to the maxscale they can set it to whatever value they can set it. But
we are expecting not to cause any memory problem on the maxscale instance if its "Don't Limit" option is selected.

At least please do it, only when it is selected max_rows to "Don't Limit" other than this not a problem.

Comment by Naresh Chandra [ 2022-01-25 ]

Hi Duong,

As the max_rows=Don't Limit is causing memory issue for big tables, any how after login to the maxscale they can set it to whatever value they can set it. But
we are expecting not to cause any memory problem on the maxscale instance if its "Don't Limit" option is selected.

At least please do it, only when it is selected max_rows to "Don't Limit" other than this not a problem.

OR

Give this as a separate option like SQL_YOG for only Don't Limit option?

Comment by Duong Thien Ly [ 2022-02-04 ]

Hi naresh.chandra@copart.com,
I think removing the `Don't Limit` option would be the simplest way as you said It could cause memory issues when the user chooses it. So the best option is just to remove it

Comment by Naresh Chandra [ 2022-02-04 ]

Hi Duong,

Thanks for the update.

Yes, it would be good if we can remove and also provide range/pagination option if possible.

and one more thing the limit rows option, you may provide separately instead of removing permanently it like SQL yog.
Can you please shift the Run/Stop button and limit rows options like the below screenshot.

Comment by Naresh Chandra [ 2022-02-09 ]

Hi Duong,

Any update on this?

Comment by Duong Thien Ly [ 2022-02-10 ]

HI naresh.chandra@copart.com, I'll remove the `Don't Limit` option in the upcoming release. i.e 6.2.2 or 6.2.3.
About the range/pagination option, there is a ticket for it that you created which is https://jira.mariadb.org/browse/MXS-3952.
About the position of the run button, thank you for the suggestion, we'll consider it.

Comment by Naresh Chandra [ 2022-02-10 ]

Hi Duong,

Thanks for the update.

Generated at Thu Feb 08 04:25:10 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.