[MXS-363] rpm building seems to do something wrong with maxscale libraries Created: 2015-09-11  Updated: 2015-12-01  Resolved: 2015-11-30

Status: Closed
Project: MariaDB MaxScale
Component/s: build, Packaging
Affects Version/s: 1.3.0
Fix Version/s: 1.3.0

Type: Bug Priority: Minor
Reporter: Simon J Mudd Assignee: markus makela
Resolution: Fixed Votes: 0
Labels: None


 Description   

Not critical but looks very ugly and should probably be fixed for 1.3

I see this when installing a test binary built as an rpm.

[root@testhost ~]# rpm ivh /some/path/to/maxscale-1.2.1.8-x86_64.rpm
Preparing... ########################################### [100%]
1:maxscale ########################################### [100%]
/sbin/ldconfig: /usr/lib64/maxscale/libnamedserverfilter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libregexfilter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libmaxinfo.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libtopfilter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libtelnetd.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libndbclustermon.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libdebugcli.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libcli.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libtestfilter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libshardrouter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libdbfwfilter.so is not a symbolic link

/sbin/ldconfig: /usr/lib64/maxscale/libbinlogrouter.so is not a symbolic link
...

This looks quite ugly and broken.
Note the rpm install actually works but this looks like it needs some attention, if not now, at some later point in time.

Seen on RHEL/CentOS 6.

Also notice the rpm name generated from cmake .. -LH -DPACKAGE=Y -DWITH_MAXSCALE_CNF=N; cmake ..; make package is not correct. Again a minor thing but it would be good to make it look normal, maybe something like:

maxscale-1.2.1.8-1.el6.x86_64.rpm

I think that using -DWITH_MAXSCALE_CNF=N should not be necessary. The rpm spec file should configure /etc/maxscale.cnf as %config ... (noreplace) etc.

Basically the rpm generation needs a bit of love.

That said the library setup obviously upsets /sbin/ldconfig so that really should be resolved.



 Comments   
Comment by markus makela [ 2015-11-30 ]

The library targets in CMake were missing the VERSION property which was the reason no symlinks were made of the libraries. This is now fixed and the proper soname versions for each library are used.

Comment by Simon J Mudd [ 2015-12-01 ]

Excellent.
Thanks.
Can you say what in what commit this is fixed?

Comment by markus makela [ 2015-12-01 ]

The final commit which includes all the changes is 3cd648fa0994fb167bf8ed278afcf74820ec5eaf .

Comment by Simon J Mudd [ 2015-12-01 ]

Hi Markus,

thanks for clarifying.

Generated at Thu Feb 08 03:58:44 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.