[MXS-34] bugzillaId-733: Init-script deletes bin/maxscale Created: 2015-01-17  Updated: 2015-03-19

Status: Closed
Project: MariaDB MaxScale
Component/s: Core
Affects Version/s: 1.0.5
Fix Version/s: 1.0.6

Type: Bug Priority: Major
Reporter: sami.ahlroos Assignee: markus makela
Resolution: Unresolved Votes: 0
Labels: None
Environment:

Linux


 Description   

This is imported from bugzilla item: http://bugs.mariadb.com/show_bug.cgi?id=733

Description Sami Ahlroos 2015-02-17 11:26:42 UTC
On Ubuntu 12.0.5 LTS (Precise), the package installed using APT from "deb [arch=amd64] http://downloads.mariadb.com/software/MaxScale/maxscale/DEB precise main" has a small bug in the provided init-script.

In function stop, the script is calling "killproc -p $PIDFILE $DAEMON", but should be using $MAXSCALE_PIDFILE. As $PIDFILE is not defined, MaxScale binary ($DAEMON) actually gets deleted.

 Comments   
Comment by Dipti Joshi (Inactive) [ 2015-03-10 ]

This is imported from comment history in bugzilla

Comment 1 Timofey Turenko 2015-02-17 12:14:17 UTC
is it related to https://github.com/mariadb-corporation/MaxScale/pull/71 ?

Comment 2 Sami Ahlroos 2015-02-17 12:24:38 UTC
Looks like the same issue, yes.

But instead of removing the call to "killproc" changing the parameter $PIDFILE to $MAXSCALE_PIDFILE should fix it. Just like in function start().
Comment 3 Sami Ahlroos 2015-02-17 13:48:59 UTC
(In reply to comment #2)
> $PIDFILE to $MAXSCALE_PIDFILE should fix it. Just like in function start().

"Just like in function reload()" I meant.

Comment 4 Massimiliano 2015-02-20 12:07:37 UTC
I'm testing the init script on Ubuntu 14.04, stopping a running maxscale.

I cannot see the maxscale executable file being deleted.

Then I tried $MAXSCALE_PIDFILE instead of $PIDFILE but I got error message:

  • Stopping MaxScale /sbin/start-stop-daemon: signal value must be numeric or name of signal (KILL, INT, ...)
    Try '/sbin/start-stop-daemon --help' for more information.

I found that removing killproc from stop works anyway.

Same action as in https://github.com/mariadb-corporation/MaxScale/pull/71/

So that might be applied soon

Generated at Thu Feb 08 03:56:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.