[MXS-330] Insufficient error handling in httpd.c Created: 2015-08-24 Updated: 2017-12-01 Resolved: 2016-03-23 |
|
| Status: | Closed |
| Project: | MariaDB MaxScale |
| Component/s: | httpd |
| Affects Version/s: | 1.2.0 |
| Fix Version/s: | 1.4.1 |
| Type: | New Feature | Priority: | Major |
| Reporter: | martin brampton (Inactive) | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
All |
||
| Issue Links: |
|
||||||||
| Description |
|
Function httpd_accept in httpd.c does not write any error logs if things fail. In branch
which adds a check to handle failure of the session_alloc call. However, it would appear that the DCB that was created on line 348 is still hanging around to no purpose and probably needs to be sent to dcb_close(). |
| Comments |
| Comment by martin brampton (Inactive) [ 2015-08-24 ] |
|
Same problem exists in maxscaled.c |
| Comment by Dipti Joshi (Inactive) [ 2015-09-10 ] |
|
martin brampton Since |
| Comment by martin brampton (Inactive) [ 2015-09-11 ] |
|
I'm not aware that anyone has done any work on the specific issue identified here. So far as I know, it is not in progress. |
| Comment by Johan Wikman [ 2015-09-11 ] |
|
This issue is fixed in both httpd.c and maxscaled.c in branch telnetd.c also handles the case that the session creation fails and in mysql_client.c a session is not created. So it seems that once |
| Comment by Dipti Joshi (Inactive) [ 2015-09-11 ] |
|
johan.wikman Can we put this "In Progress" status then ? Thanks, |
| Comment by Johan Wikman [ 2015-09-11 ] |
|
In progress or duplicate. |
| Comment by Dipti Joshi (Inactive) [ 2015-09-11 ] |
|
In Progress |
| Comment by Johan Wikman [ 2015-11-17 ] |
|
Fixed by the merge of |
| Comment by martin brampton (Inactive) [ 2015-11-17 ] |
|
This module still needs a good deal of improvement. |
| Comment by Johan Wikman [ 2015-11-17 ] |
|
Ok, thought this was about that specific thing in the _accept-functions. Since it's of generic nature, I'll change it into an improvement. |
| Comment by Dipti Joshi (Inactive) [ 2015-11-17 ] |
|
Since it is improvement - is the fixedVersion 1.3.0 or open ? |
| Comment by Johan Wikman [ 2015-11-17 ] |
|
We will have to go through this and other issues and decide whether it is important enough to definitely include in 1.3 or whether it can wait. While error handling always can and should be improved until it is sufficiently good, I don't recall having seen particular problems related to this area. |
| Comment by Johan Wikman [ 2015-12-03 ] |
|
Moving to 1.3.1 |
| Comment by Johan Wikman [ 2016-03-23 ] |
|
Closing as the two particular issues referred to by the description - no check of the session creation having succeeded and failure to close the DCB in case of error - are fixed already in 1.3.0. |