[MXS-2596] When log_info is enabled, MaxScale should print verbose information during admin interface startup Created: 2019-07-11  Updated: 2019-10-17  Resolved: 2019-10-16

Status: Closed
Project: MariaDB MaxScale
Component/s: REST-API
Affects Version/s: 2.3.9
Fix Version/s: 2.5.0

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: markus makela
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MXS-2597 MaxScale doesn't handle errors from m... Closed

 Description   

When log_info is enabled, MaxScale doesn't currently print any verbose information during the startup process of the admin interfaceL

https://github.com/mariadb-corporation/MaxScale/blob/maxscale-2.3.9/server/core/gateway.cc#L2213

https://github.com/mariadb-corporation/MaxScale/blob/maxscale-2.3.9/server/core/admin.cc#L378

This can make problems with the startup process more difficult to debug.



 Comments   
Comment by markus makela [ 2019-07-25 ]

I think this is fixed by https://github.com/mariadb-corporation/MaxScale/commit/bc2f7f4040f3a44617100d23e64948d9db140dfe as there's no more extra information available from the daemon process that maxscale could log.

Comment by Geoff Montee (Inactive) [ 2019-07-25 ]

Hi markus makela,

Yeah, hopefully the fix for MXS-2597 provides enough information most of the time.

For this issue, I was primarily requesting some kind of message like this, in case the service failed to start, and microhttpd didn't provide any useful information:

Attempting to start REST API on [127.0.0.1]:8989

The error message added by MXS-2597 doesn't mention "REST API" at all, so it might still be a good idea to add a message like this during startup. That way, if the user sees an "HTTP daemon error" in the log, then it will be clearer that it was caused by starting the REST API.

Another thing that I noticed about the current log messages is that they don't use a consistent name for the REST API. For example, we can see that when the service successfully starts, the log message refers to the "REST API", but when the service fails to start, the log message refers to the "admin interface."

https://github.com/mariadb-corporation/MaxScale/blob/maxscale-2.3.9/server/core/gateway.cc#L2227

https://github.com/mariadb-corporation/MaxScale/blob/maxscale-2.3.9/server/core/gateway.cc#L2231

It may be more user friendly if the log messages used a consistent name.

Comment by markus makela [ 2019-10-16 ]

Use REST API consistently in the error messages.

Generated at Thu Feb 08 04:15:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.