[MXS-2479] Don't throw error for PAM_TEXT_INFO in PAM conversation function Created: 2019-05-10 Updated: 2020-08-25 Resolved: 2019-05-28 |
|
| Status: | Closed |
| Project: | MariaDB MaxScale |
| Component/s: | Authenticator |
| Affects Version/s: | 2.3.6 |
| Fix Version/s: | 2.3.8 |
| Type: | Bug | Priority: | Major |
| Reporter: | Geoff Montee (Inactive) | Assignee: | Esa Korhonen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Sprint: | MXS-SPRINT-82, MXS-SPRINT-83 | ||||||||||||
| Description |
|
The PAM conversation function currently throws an error if it encounters any messages that are not PAM_PROMPT_ECHO_OFF or PAM_PROMPT_ECHO_ON: This means that a user's MaxScale log can fill up with error messages like the following:
If msg_style=4, then it is of the type PAM_TEXT_INFO:
These appear to be harmless messages:
http://www.linux-pam.org/Linux-PAM-html/mwg-expected-by-module-item.html#mwg-pam_conv That doesn't really seem worthy of an error that causes the connection to fail. It seems like it would be better to log PAM_TEXT_INFO messages with MXS_NOTICE or MXS_INFO instead of MXS_ERROR, and then also return PAM_SUCCESS, so it doesn't count as a failure. |