Introduce duration suffixes
(MXS-2327)
|
|
| Status: | Closed |
| Project: | MariaDB MaxScale |
| Component/s: | Core |
| Affects Version/s: | 2.3.2 |
| Fix Version/s: | 2.4.0 |
| Type: | Sub-Task | Priority: | Minor |
| Reporter: | Austin Rutherford (Inactive) | Assignee: | Johan Wikman |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | MXS-SPRINT-75, MXS-SPRINT-76, MXS-SPRINT-77, MXS-SPRINT-78, MXS-SPRINT-79, MXS-SPRINT-80, MXS-SPRINT-81 |
| Description |
|
The maxscale.cnf file has some fields that use seconds and some that use milliseconds. Customers can get these different grains to be confusing. All timeouts/fields with time should either be milliseconds or seconds. Tactically, we could put comments after the field in the default .cnf file. monitor_interval=2500 # this field is in milliseconds |
| Comments |
| Comment by markus makela [ 2019-01-10 ] | |||
|
Another idea would be to add support for suffixed time types like we have for sizes:
| |||
| Comment by Johan Wikman [ 2019-01-10 ] | |||
|
Time suffixes is the way to go. That way it's completely unambiguous what the number means. | |||
| Comment by Austin Rutherford (Inactive) [ 2019-02-05 ] | |||
|
Looks good. One item though - if they don't add a suffix they should IMO either error out or default to the same grain (seconds or milleseconds) | |||
| Comment by Johan Wikman [ 2019-02-13 ] | |||
|
It's going to be like this;
|