[MXS-2035] available_when_donor don't working with mariabackup sst method Created: 2018-08-31  Updated: 2018-09-15  Resolved: 2018-09-15

Status: Closed
Project: MariaDB MaxScale
Component/s: galeramon
Affects Version/s: 2.2.13
Fix Version/s: 2.2.14

Type: Bug Priority: Major
Reporter: Petrov Aleksey Assignee: markus makela
Resolution: Fixed Votes: 0
Labels: None


 Description   

When using 

wsrep_sst_method=mariabackup

maxscale option "available_when_donor" don't working.

In file server/modules/monitor/galeramon/galeramon.c method "using_xtrabackup" checks only xtrabackup sst_method.

 Comments   
Comment by markus makela [ 2018-09-13 ]

mariabackup is now treated as an alias for xtrabackup.

Comment by Petrov Aleksey [ 2018-09-14 ]

I looked at the version 2.2.14.
This is correct condition? (without "== 0" for the right operand)

 if (row[1] && (strcmp(row[1], "xtrabackup") == 0 || strcmp(row[1], "mariabackup")))
 
            {
 
                rval = true;
 
            }

Comment by markus makela [ 2018-09-14 ]

This is embarrassing...

That is indeed wrong, we'll fix it immediately. Thank you for spotting this, you prevented a bug.

Generated at Thu Feb 08 04:11:12 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.